From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750811AbXBWDei (ORCPT ); Thu, 22 Feb 2007 22:34:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750812AbXBWDei (ORCPT ); Thu, 22 Feb 2007 22:34:38 -0500 Received: from mx1.redhat.com ([66.187.233.31]:56130 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750811AbXBWDeh (ORCPT ); Thu, 22 Feb 2007 22:34:37 -0500 Message-ID: <45DE60C1.2020103@redhat.com> Date: Thu, 22 Feb 2007 22:34:25 -0500 From: Rik van Riel Organization: Red Hat, Inc User-Agent: Thunderbird 1.5.0.7 (X11/20061008) MIME-Version: 1.0 To: 7eggert@gmx.de CC: Christoph Lameter , linux-kernel , linux-mm , Andrew Morton Subject: Re: [PATCH] free swap space when (re)activating page References: <7Pk3X-bD-17@gated-at.bofh.it> <7QvgM-3aK-3@gated-at.bofh.it> <7QDeB-7KY-11@gated-at.bofh.it> <7QGc7-3ZB-13@gated-at.bofh.it> <7QGlP-4e1-11@gated-at.bofh.it> <7QHUO-6RS-5@gated-at.bofh.it> <7QJ9Y-mo-1@gated-at.bofh.it> <7QJk7-zW-51@gated-at.bofh.it> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Bodo Eggert wrote: > Rik van Riel wrote: > > +++ linux-2.6.20.noarch/mm/swap.c 2007-02-20 06:44:17.000000000 -0500 > @@ -420,6 +420,26 @@ void pagevec_strip(struct pagevec *pvec) > >> + if (printk_ratelimit()) >> + printk("kswapd freed a swap space\n"); >> > > NOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO!!!!!!!!!!! > > 1) This message is a debug message! You forgot to set the printk level. Doh, I forgot to cut it out of the patch when I fixed it according to Christoph's hint. This chunk should be removed from the patch... Andrew, I'll send you a new one tomorrow morning. -- Politics is the struggle between those who want to make their country the best in the world, and those who believe it already is. Each group calls the other unpatriotic. From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <45DE60C1.2020103@redhat.com> Date: Thu, 22 Feb 2007 22:34:25 -0500 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH] free swap space when (re)activating page References: <7Pk3X-bD-17@gated-at.bofh.it> <7QvgM-3aK-3@gated-at.bofh.it> <7QDeB-7KY-11@gated-at.bofh.it> <7QGc7-3ZB-13@gated-at.bofh.it> <7QGlP-4e1-11@gated-at.bofh.it> <7QHUO-6RS-5@gated-at.bofh.it> <7QJ9Y-mo-1@gated-at.bofh.it> <7QJk7-zW-51@gated-at.bofh.it> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: 7eggert@gmx.de Cc: Christoph Lameter , linux-kernel , linux-mm , Andrew Morton List-ID: Bodo Eggert wrote: > Rik van Riel wrote: > > +++ linux-2.6.20.noarch/mm/swap.c 2007-02-20 06:44:17.000000000 -0500 > @@ -420,6 +420,26 @@ void pagevec_strip(struct pagevec *pvec) > >> + if (printk_ratelimit()) >> + printk("kswapd freed a swap space\n"); >> > > NOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO!!!!!!!!!!! > > 1) This message is a debug message! You forgot to set the printk level. Doh, I forgot to cut it out of the patch when I fixed it according to Christoph's hint. This chunk should be removed from the patch... Andrew, I'll send you a new one tomorrow morning. -- Politics is the struggle between those who want to make their country the best in the world, and those who believe it already is. Each group calls the other unpatriotic. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org