All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: dsaxena@plexity.net
Cc: Linus Torvalds <torvalds@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Allow kernel to build on Cygwin
Date: Fri, 23 Feb 2007 16:18:35 -0800	[thread overview]
Message-ID: <45DF845B.3020602@zytor.com> (raw)
In-Reply-To: <20070223034343.GA3320@plexity.net>

Deepak Saxena wrote:
> This patch contains a set of small fixes to allow the kernel to build under
> the Cygwin environment, which is unfortunately used by more people than
> one would think in the embedded world. :(
> 
> Signed-off-by: Deepak Saxena <dsaxena@mvista.com>

I have one major problem with this patch: none of the hacks are 
commented, which invites cargo cult programming by people who needs to 
further maintain the code.

	-hpa

      parent reply	other threads:[~2007-02-24  0:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-23  3:43 [PATCH] Allow kernel to build on Cygwin Deepak Saxena
2007-02-23 20:37 ` Matthieu CASTET
2007-02-23 23:17   ` Deepak Saxena
2007-02-24  0:17 ` H. Peter Anvin
2007-02-24 22:55   ` Jan Engelhardt
2007-02-24 23:40     ` H. Peter Anvin
2007-02-24  0:18 ` H. Peter Anvin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45DF845B.3020602@zytor.com \
    --to=hpa@zytor.com \
    --cc=dsaxena@plexity.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.