From: Tejun Heo <htejun@gmail.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: jeff@garzik.org, linux-ide@vger.kernel.org, jeremy@sgi.com
Subject: Re: [PATCH 2.6.21-rc1] sata_vsc: refactor vsc_sata_interrupt and hook up error handling
Date: Sat, 24 Feb 2007 13:06:16 +0900 [thread overview]
Message-ID: <45DFB9B8.60905@gmail.com> (raw)
In-Reply-To: <20070223233643.8535.1788.stgit@dwillia2-linux.ch.intel.com>
Dan Williams wrote:
> Separate sata_vsc interrupt handling into a normal (per-port) path and an
> error path with the addition of vsc_port_intr and vsc_error_intr
> respectively. The error path handles interrupt based
> hotplug events which requires the definition of vsc_freeze and vsc_thaw.
>
> Note: vsc_port_intr has a workaround for unexpected interrupts that occur
> during polled commands. This fixes a regression between 2.6.19 and 2.6.20.
>
> Changes in take2:
> * removed definition of invalid fis bit
> * let standard ata-error-handling handle the serror register
> * clear all unhandled interrupts
> * revert changes to vsc_intr_mask_update (vsc_thaw enables all interrupts)
> * use unlikely() for the pci-abort and not-our-interrupt cases in vsc_sata_interrupt
>
> Changes in take3:
> * Unify the "add" + "hook-up" patches into this single patch
>
> [htejun@gmail.com: clean up comments and suggestions]
> Cc: Jeremy Higdon <jeremy@sgi.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Acked-by: Tejun Heo <htejun@gmail.com>
--
tejun
next prev parent reply other threads:[~2007-02-24 4:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-23 23:36 [PATCH 2.6.21-rc1] sata_vsc: refactor vsc_sata_interrupt and hook up error handling Dan Williams
2007-02-24 4:06 ` Tejun Heo [this message]
2007-02-25 1:54 ` Jeff Garzik
2007-02-28 8:02 ` Jeremy Higdon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45DFB9B8.60905@gmail.com \
--to=htejun@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=jeff@garzik.org \
--cc=jeremy@sgi.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.