Re: [PATCH] Print error code in page faults

[Chuck Ebbert <cebbert@redhat.com>]

Glauber de Oliveira Costa wrote:
> When a page faults comes from a kernel space, the printed summary
> leaves us clueless about what kind of access was being tried (which
> is encoded in the error_code variable).
> 
> Having it promply available may ease debugging in a bunch of
> situations.
> 
> Signed-off-by: Glauber de Oliveira Costa <gcosta@redhat.com>
> 
> 
> 
> ------------------------------------------------------------------------
> 
> diff --git a/arch/x86_64/mm/fault.c b/arch/x86_64/mm/fault.c
> index 6ada723..e65522e 100644
> --- a/arch/x86_64/mm/fault.c
> +++ b/arch/x86_64/mm/fault.c
> @@ -539,7 +539,7 @@ no_context:
>  		printk(KERN_ALERT "Unable to handle kernel NULL pointer dereference");
>  	else
>  		printk(KERN_ALERT "Unable to handle kernel paging request");
> -	printk(" at %016lx RIP: \n" KERN_ALERT,address);
> +	printk(" at %016lx (error=0x%02lx) RIP: \n" KERN_ALERT, error_code, address);
>  	printk_address(regs->rip);
>  	dump_pagetable(address);
>  	tsk->thread.cr2 = address;

Umm, it's already there, right after the word "Oops".


Oops: 0002 [1] SMP
      ^^^^