From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-ide@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Komuro <komurojun-mbn@nifty.com>
Subject: Re: [PATCH] libata: clear drvdata in ata_host_release()
Date: Sat, 24 Feb 2007 20:51:27 -0500 [thread overview]
Message-ID: <45E0EB9F.3050001@garzik.org> (raw)
In-Reply-To: <20070224074823.GA20322@htj.dyndns.org>
Tejun Heo wrote:
> ata_host_release() uses drvdata to determine ata_host to release and
> clearing drvdata in ->remove_one causes NULL pointer deference. Clear
> drvdata only in ata_host_release() after all resources are freed.
>
> This bug was first analyzed by Alan Cox for pata_pcmcia.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> ---
> Alan, this is the bug you talked about, right? I took the fix from
> "[BUG] PATA_PCMCIA does not work" and expanded it. If this isn't the
> one, please let me know. Thanks.
Has a tester confirmed that this patch fixes the problem, and supercedes
Alan's patch?
Jeff
next prev parent reply other threads:[~2007-02-25 1:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-24 7:48 [PATCH] libata: clear drvdata in ata_host_release() Tejun Heo
2007-02-24 13:57 ` Alan
2007-02-25 1:51 ` Jeff Garzik [this message]
2007-02-25 13:28 ` Alan
2007-02-27 13:33 ` [PATCH] libata: clear drvdata in ata_host_release(), take#2 Tejun Heo
2007-03-02 1:16 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E0EB9F.3050001@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=komurojun-mbn@nifty.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.