From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Zachary Amsden <zach@vmware.com>
Cc: Anthony Liguori <anthony@codemonkey.ws>, linux-kernel@vger.kernel.org
Subject: Re: [RFC] Use para_fill instead of vmi_get_function for APIC ops
Date: Mon, 26 Feb 2007 17:36:01 -0800 [thread overview]
Message-ID: <45E38B01.2010509@goop.org> (raw)
In-Reply-To: <45E37EB5.7070100@vmware.com>
Zachary Amsden wrote:
> Patch looks good, thanks. But the whole para_fill / vmi_get_function
> stuff could probably be done even cleaner. It was just a helper at
> first to work around the awkward syntax, and it is still a bit ugly,
> but I haven't come up with a better solution yet, mostly because with
> the new inlining work Jeremy is doing, we might want to start doing
> selective inlining, in which case I'll have to go back over the code
> anyway to clean everything to get the logic right in all cases.
Yes, my patching updates make pretty much all the pv_ops patchable,
including the apic ones. The simple thing is to fill out paravirt_ops
with the appropriate pointers, then set the .patch operation to
paravirt_default_patch, which will basically turn them all into direct
calls. If you want to start inlining stuff, then you can do that too.
J
next prev parent reply other threads:[~2007-02-27 1:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-27 0:06 [RFC] Use para_fill instead of vmi_get_function for APIC ops Anthony Liguori
2007-02-27 0:43 ` Zachary Amsden
2007-02-27 0:49 ` Anthony Liguori
2007-02-27 1:00 ` Zachary Amsden
2007-02-27 1:36 ` Jeremy Fitzhardinge [this message]
2007-02-27 16:17 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E38B01.2010509@goop.org \
--to=jeremy@goop.org \
--cc=anthony@codemonkey.ws \
--cc=linux-kernel@vger.kernel.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.