From: Jeff Garzik <jeff@garzik.org>
To: Ron Mercer <ron.mercer@qlogic.com>
Cc: romieu@fr.zoreil.com, benjamin.li@qlogic.com, netdev@vger.kernel.org
Subject: Re: [PATCH 01/13] qla3xxx: Return proper error codes when the 4022/4032 is being probed
Date: Tue, 27 Feb 2007 04:22:07 -0500 [thread overview]
Message-ID: <45E3F83F.6010003@garzik.org> (raw)
In-Reply-To: <11725168032993-git-send-email-ron.mercer@qlogic.com>
Ron Mercer wrote:
> From: Benjamin Li <benjamin.li@qlogic.com>
>
> The return code was not properly set when when allocating memory or mapping
> memory failed. Depending on the stack, the return code would sometimes
> return 0, which indicates everything was ok, when in fact there was an error.
> This would cause trouble when the module was removed. Now, we will pass
> back the proper return code when an error occurs during the PCI probe.
>
> Signed-off-by: Benjamin Li <benjamin.li@qlogic.com>
> Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>
> ---
> drivers/net/qla3xxx.c | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
applied 1-13
next prev parent reply other threads:[~2007-02-27 9:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-26 19:04 [PATCH 0/13] qla3xxx: bugfixes and cleanup after IBM/Redhat testing Ron Mercer
2007-02-26 19:06 ` [PATCH 01/13] qla3xxx: Return proper error codes when the 4022/4032 is being probed Ron Mercer
2007-02-27 9:22 ` Jeff Garzik [this message]
2007-03-01 0:48 ` [PATCH] qla3xxx: bugfix for line omitted in previous patch Ron Mercer
2007-03-03 1:17 ` Jeff Garzik
2007-02-26 19:06 ` [PATCH 02/13] qla3xxx: Remove unnecessary memset() in qla3xxx_send() Ron Mercer
2007-02-26 19:06 ` [PATCH 03/13] qla3xxx: Changed to use netdev_alloc_skb() from dev_alloc_skb Ron Mercer
2007-02-26 19:06 ` [PATCH 04/13] qla3xxx: Add ethtool functionality to report pause parameters Ron Mercer
2007-02-26 19:06 ` [PATCH 05/13] qla3xxx: Fix deadlock issue on error paths Ron Mercer
2007-02-26 19:06 ` [PATCH 06/13] qla3xxx: Remove API to change MTU Ron Mercer
2007-02-26 19:06 ` [PATCH 07/13] qla3xxx: Dynamically size the rx buffer queue based on the MTU Ron Mercer
2007-02-26 19:06 ` [PATCH 08/13] qla3xxx: Clean up receive process Ron Mercer
2007-02-26 19:06 ` [PATCH 09/13] qla3xxx: bugfix: Fixed jumbo frame handling for 3032 chip Ron Mercer
2007-02-26 19:06 ` [PATCH 10/13] qla3xxx: Check return code from pci_map_single() in ql_release_to_lrg_buf_free_list(), ql_populate_free_queue(), ql_alloc_large_buffers(), and ql3xxx_send() Ron Mercer
2007-02-26 19:06 ` [PATCH 11/13] qla3xxx: bugfix tx reset after stress conditions Ron Mercer
2007-02-26 19:06 ` [PATCH 12/13] qla3xxx: Kernic Panic on pSeries under " Ron Mercer
2007-02-26 19:06 ` [PATCH 13/13] qla3xxx: Bumping driver version number Ron Mercer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E3F83F.6010003@garzik.org \
--to=jeff@garzik.org \
--cc=benjamin.li@qlogic.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=ron.mercer@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.