Re: [PATCH]: Fix __devinit & __devexit declarations in de2104x driver

[Prarit Bhargava <prarit@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 644 bytes --]



Jeff Garzik wrote:
> Prarit Bhargava wrote:
>> Resending (originally sent 2007-02-14).
>>
>> __devinit & __devexit cleanups for de2104x driver.
>>
>> Fixes MODPOST warnings similar to:
>>
>> WARNING: drivers/net/tulip/de2104x.o - Section mismatch: reference to
>> .init.text:de_init_one from .data.rel.local after 'de_driver' (at 
>> offset 0x20)
>> WARNING: drivers/net/tulip/de2104x.o - Section mismatch: reference to
>> .exit.text:de_remove_one from .data.rel.local after 'de_driver' (at 
>> offset 0x28)
>>
>> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
>
> doesn't apply to current kernel

Updated patch to latest git...

P.

>
>

[-- Attachment #2: 228736-v2.patch --]
[-- Type: text/plain, Size: 1467 bytes --]

__devinit & __devexit cleanups for de2104x driver.

Fixes MODPOST warnings similar to:

WARNING: drivers/net/tulip/de2104x.o - Section mismatch: reference to
.init.text:de_init_one from .data.rel.local after 'de_driver' (at offset 0x20)
WARNING: drivers/net/tulip/de2104x.o - Section mismatch: reference to
.exit.text:de_remove_one from .data.rel.local after 'de_driver' (at offset 0x28)

Signed-off-by: Prarit Bhargava <prarit@redhat.com>

diff --git a/drivers/net/tulip/de2104x.c b/drivers/net/tulip/de2104x.c
index 9d67f11..55739c7 100644
--- a/drivers/net/tulip/de2104x.c
+++ b/drivers/net/tulip/de2104x.c
@@ -1685,7 +1685,7 @@ static const struct ethtool_ops de_ethtool_ops = {
 	.get_regs		= de_get_regs,
 };
 
-static void __init de21040_get_mac_address (struct de_private *de)
+static void __devinit de21040_get_mac_address (struct de_private *de)
 {
 	unsigned i;
 
@@ -1703,7 +1703,7 @@ static void __init de21040_get_mac_address (struct de_private *de)
 	}
 }
 
-static void __init de21040_get_media_info(struct de_private *de)
+static void __devinit de21040_get_media_info(struct de_private *de)
 {
 	unsigned int i;
 
@@ -1765,7 +1765,7 @@ static unsigned __devinit tulip_read_eeprom(void __iomem *regs, int location, in
 	return retval;
 }
 
-static void __init de21041_get_srom_info (struct de_private *de)
+static void __devinit de21041_get_srom_info (struct de_private *de)
 {
 	unsigned i, sa_offset = 0, ofs;
 	u8 ee_data[DE_EEPROM_SIZE + 6] = {};