All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <paolo.bonzini@lu.unisi.ch>
To: git@vger.kernel.org
Subject: [PATCH] git-archimport does not cope with empty summaries
Date: Tue, 27 Feb 2007 14:34:17 +0100	[thread overview]
Message-ID: <45E43359.3030400@lu.unisi.ch> (raw)

I got this while importing bonzini@gnu.org--2004b/lightning--stable--1.2 
(archive available at 
http://www.inf.unisi.ch/phd/bonzini/webdav/bonzini@gnu.org--2004b via 
webdav).

The patch seems pretty obvious to me:

2007-02-27  Paolo Bonzini  <bonzini@gnu.org>

         * git-archimport (parselog): Cope with an empty summary.

--- /usr/bin/git-archimport     2007-01-09 21:15:39.000000000 +0100
+++ ./git-archimport    2007-02-27 14:28:33.000000000 +0100
@@ -780,7 +780,11 @@
      }

      # post-processing:
-    $ps->{summary} = join("\n",@{$ps->{summary}})."\n";
+    if (defined $ps->{summary}) {
+        $ps->{summary} = join("\n",@{$ps->{summary}})."\n";
+    } else {
+        $ps->{summary} = "empty summary\n";
+    }
      $ps->{message} = join("\n",@$log);

      # skip Arch control files, unescape pika-escaped files

                 reply	other threads:[~2007-02-28 20:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45E43359.3030400@lu.unisi.ch \
    --to=paolo.bonzini@lu.unisi.ch \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.