* [Xenomai-core] [CAN] SIOC* clash
@ 2007-02-27 14:28 Jan Kiszka
2007-02-27 14:45 ` [Xenomai-core] " Wolfgang Grandegger
0 siblings, 1 reply; 2+ messages in thread
From: Jan Kiszka @ 2007-02-27 14:28 UTC (permalink / raw)
To: Wolfgang Grandegger; +Cc: xenomai-core
[-- Attachment #1: Type: text/plain, Size: 583 bytes --]
Hi Wolfgang,
just realised that there is an ABI mine laid in rtcan.h:
#ifndef SIOCGIFINDEX
#define SIOCGIFINDEX \
_IOWR(RTIOC_TYPE_CAN, 0x00, struct ifreq)
#endif
So, if you happen to have included sys/ioctl.h earlier in your
application, an incompatible IOCTL code will be used in user space.
I recommend to switch to existing IOCTL codes where available (that's
what we do in RTnet as well). This may also mean betting on the current
IOCTL assignments in Socket-CAN, that they will survive unchanged the
eventual merge into Linux mainline.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread* [Xenomai-core] Re: [CAN] SIOC* clash
2007-02-27 14:28 [Xenomai-core] [CAN] SIOC* clash Jan Kiszka
@ 2007-02-27 14:45 ` Wolfgang Grandegger
0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Grandegger @ 2007-02-27 14:45 UTC (permalink / raw)
To: Jan Kiszka; +Cc: xenomai-core
Jan Kiszka wrote:
> Hi Wolfgang,
>
> just realised that there is an ABI mine laid in rtcan.h:
>
> #ifndef SIOCGIFINDEX
> #define SIOCGIFINDEX \
> _IOWR(RTIOC_TYPE_CAN, 0x00, struct ifreq)
> #endif
>
> So, if you happen to have included sys/ioctl.h earlier in your
> application, an incompatible IOCTL code will be used in user space.
>
> I recommend to switch to existing IOCTL codes where available (that's
> what we do in RTnet as well). This may also mean betting on the current
> IOCTL assignments in Socket-CAN, that they will survive unchanged the
> eventual merge into Linux mainline.
D'accord, I will change this with the next update.
Wolfgang.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-02-27 14:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-27 14:28 [Xenomai-core] [CAN] SIOC* clash Jan Kiszka
2007-02-27 14:45 ` [Xenomai-core] " Wolfgang Grandegger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.