From: Jeff Garzik <jeff@garzik.org>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: linux-ide@vger.kernel.org
Subject: Re: [RFT] sata_promise: intermittent errors bug hunting
Date: Tue, 27 Feb 2007 18:16:11 -0500 [thread overview]
Message-ID: <45E4BBBB.90504@garzik.org> (raw)
In-Reply-To: <200702272225.l1RMPfSt021674@harpo.it.uu.se>
Mikael Pettersson wrote:
> + if (hp->flags & PDC_FLAG_GEN_II) {
> + /* record ASIC rev */
> + pci_read_config_byte(pdev, PCI_REVISION_ID, &hp->asic_rev);
> +
> +#if 1
> + /* set cache line size = 1 */
> + pci_read_config_byte(pdev, PCI_CACHE_LINE_SIZE, &tmp);
> + printk("%s: changing pci_cache_line_size from %#02x to 0x01\n",
> + __FUNCTION__, tmp);
> + pci_write_config_byte(pdev, PCI_CACHE_LINE_SIZE, 0x01);
> +#endif
This bit strikes me as somewhat dubious. If this proves to actually fix
something, I would start by exporting pci_set_cacheline_size() in
drivers/pci/pci.c, using it, and seeing if that helps.
Jeff
next prev parent reply other threads:[~2007-02-27 23:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-27 22:25 [RFT] sata_promise: intermittent errors bug hunting Mikael Pettersson
2007-02-27 23:16 ` Jeff Garzik [this message]
2007-02-28 21:29 ` Andreas Arens
2007-03-02 11:51 ` Tomi Orava
-- strict thread matches above, loose matches on Subject: below --
2007-03-02 12:52 Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E4BBBB.90504@garzik.org \
--to=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=mikpe@it.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.