From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: RE: [PATCH] Make x86_64 swiotlb code to support dma_ops [2/2] Date: Thu, 01 Mar 2007 08:05:01 +0000 Message-ID: <45E6973D.76E4.0078.0@novell.com> References: <1449F58C868D8D4E9C72945771150BDFD9668D@SAUSEXMB1.amd.com> <1449F58C868D8D4E9C72945771150BDFD9668F@SAUSEXMB1.amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1449F58C868D8D4E9C72945771150BDFD9668F@SAUSEXMB1.amd.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Mark Langsdorf Cc: xen-devel@lists.xensource.com, Keir Fraser List-Id: xen-devel@lists.xenproject.org >> I'm not sure how far we'll need to deviate -- I >> suspect we'll end up with a file that look much like the >> i386/pci-dma-xen.c >> but with calls to swiotlb_xxx() replaced with dma_ops->xxx. >> Maybe we could >> even stick with just i386/pci-dma-xen.c and macro up the uses of >> swiotlb_xxx() (so that they can be replaced with uses of >> dma_ops->xxx for x86/64 by cpp). > >Given that pci-dma-xen for x86_64 is always going to have >most of the functions replaced by either SWIOTLB or an >IOMMU, would it be sufficient to copy the (known good) >implementations of dma_alloc_coherent() from the i386 >version? That is what I would have preferred from the beginning. I just didn't complain because native lib/swiotlb.c also has these, and I think they're not very difficult to fix (and also because I was afraid I already complained about too many other things). Jan