From: "Jan Beulich" <jbeulich@novell.com>
To: Keir Fraser <keir@xensource.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: Fwd: Re: struct page field arrangement
Date: Thu, 01 Mar 2007 12:50:55 +0000 [thread overview]
Message-ID: <45E6DA3F.76E4.0078.0@novell.com> (raw)
In-Reply-To: <C20C739D.A694%keir@xensource.com>
>By the way, I think your proposed patch looks okay. However we already use
>page->index for foreign pages, in netback. Perhaps page->lru is also fair
>game? :-)
Not generally, there are arch-es that use it for their own purposes (look
back at the message from Hugh I originally forwarded). So even if none of
Xen's currently supported would use it (I didn't check), I wouldn't want to
introduce a lurking issue if anyone comes up with a new port.
I didn't check what private is being used for - while it can't be used for
PageForeign's destructor pointer, perhaps netback could use that one
rather than index? Or, even more likely, netback could use mapping if
PageForeign was switched over to index (while mapping overlays ptl, that
is benign to netback as it's not dealing with pte pages). But of course,
this requires thorough auditing of other uses of index.
Jan
next prev parent reply other threads:[~2007-03-01 12:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-28 14:31 struct page field arrangement Jan Beulich
2007-02-28 21:08 ` Hugh Dickins
2007-03-01 8:42 ` Fwd: " Jan Beulich
2007-03-01 10:22 ` Keir Fraser
2007-03-01 11:45 ` Jan Beulich
2007-03-01 12:12 ` Keir Fraser
2007-03-01 12:50 ` Jan Beulich [this message]
2007-03-01 13:42 ` Keir Fraser
-- strict thread matches above, loose matches on Subject: below --
2007-03-16 11:58 Jan Beulich
2007-03-16 12:11 ` Keir Fraser
2007-03-16 12:25 ` Keir Fraser
2007-03-16 12:54 ` Jan Beulich
2007-03-16 12:37 ` Keir Fraser
2007-03-16 12:46 ` Jan Beulich
2007-03-16 13:47 Jan Beulich
2007-03-16 14:13 ` Keir Fraser
2007-03-16 14:30 ` Keir Fraser
2007-03-16 15:15 ` Jan Beulich
2007-03-16 15:30 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E6DA3F.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=keir@xensource.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.