From: Simon Arlott <simon@fire.lp0.eu>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: akpm@linux-foundation.org, arjan@linux.intel.com
Subject: [PATCH] timer: Add an initial 0.5s delay to calc_load
Date: Thu, 01 Mar 2007 18:52:24 +0000 [thread overview]
Message-ID: <45E720E8.1010809@simon.arlott.org.uk> (raw)
In-Reply-To: <45E698DF.4010006@simon.arlott.org.uk>
This adds an initial 0.5s delay to calc_load so that it avoids updating
load at the same time as tasks scheduled using round_jiffies, otherwise
the load average is badly affected by tasks that run every time calc_load
does (currently every 5s).
I'm assuming this change doesn't affect the intention of round_jiffies,
to avoid tasks waking the cpu at different times, because calc_load is
already run very often by a call from update_times(ticks) on every timer
interrupt.
Signed-off-by: Simon Arlott <simon@fire.lp0.eu>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Arjan van de Ven <arjan@linux.intel.com>
---
Without this change or an appropriate equivalent, my change to cxacru
causes the load to stay around 1.00 even when mostly idle since it now
runs every second using round_jiffies:
> [ 332.416288] cxacru_poll_status(..), jiffies=5000 [start]
> [ 332.417312] calc_load(1), count=-1, jiffies=5001 [start]
> [ 332.417322] calc_load(1), count=4999, jiffies=5001 [finish]
> [ 332.423382] cxacru_poll_status(..), jiffies=5007, next=993 [finish]
kernel/timer.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/timer.c b/kernel/timer.c
index cb1b86a..4bb21b5 100644
--- a/kernel/timer.c
+++ b/kernel/timer.c
@@ -1225,7 +1225,7 @@ EXPORT_SYMBOL(avenrun);
static inline void calc_load(unsigned long ticks)
{
unsigned long active_tasks; /* fixed-point */
- static int count = LOAD_FREQ;
+ static int count = LOAD_FREQ + HZ/2;
count -= ticks;
if (unlikely(count < 0)) {
--
1.5.0.1
--
Simon Arlott
next prev parent reply other threads:[~2007-03-01 18:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-24 15:19 round_jiffies and load average Simon Arlott
2007-03-01 9:11 ` Simon Arlott
2007-03-01 18:52 ` Simon Arlott [this message]
2007-03-01 22:52 ` [PATCH (updated)] timer: Run calc_load halfway through each round_jiffies second Simon Arlott
2002-01-01 3:05 ` Pavel Machek
2007-03-05 22:35 ` Simon Arlott
2007-03-06 18:42 ` [PATCH (update 4)] " Simon Arlott
2007-03-06 22:20 ` [PATCH (updated)] " Chuck Ebbert
2007-03-01 23:10 ` Bill Irwin
2007-03-02 10:15 ` [PATCH (update 2)] " Simon Arlott
2007-03-02 15:15 ` [PATCH (update 3)] " Simon Arlott
2007-03-02 16:35 ` Eric Dumazet
2007-03-02 17:32 ` Simon Arlott
2007-03-02 18:03 ` Eric Dumazet
2007-03-02 20:14 ` Simon Arlott
2007-03-02 22:32 ` Eric Dumazet
2007-03-02 23:54 ` Simon Arlott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E720E8.1010809@simon.arlott.org.uk \
--to=simon@fire.lp0.eu \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.