From: Ben Nizette <ben.nizette@iinet.net.au>
To: David Brownell <david-b@pacbell.net>
Cc: Dmitry Torokhov <dtor@mail.ru>,
pHilipp Zabel <philipp.zabel@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Haavard Skinnemoen <hskinnemoen@atmel.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [patch 2.6.21-rc2] gpio_keys driver shouldn't be ARM-specific
Date: Fri, 02 Mar 2007 11:18:45 +1100 [thread overview]
Message-ID: <45E76D65.30405@iinet.net.au> (raw)
In-Reply-To: <200703011551.29696.david-b@pacbell.net>
David Brownell wrote:
> The gpio_keys driver is wrongly ARM-specific; it can't build on
> other platforms with GPIO suport. This fixes that problem.
>
I did up a similar patch a few days back, you beat me too it ;). I've
been using this driver on AVR32 for a while now.
The other thing was that this driver only depends on the machine
supporting your generic GPIO conventions. Currently the Kconfig entry
for gpio_keys reads:
depends on (ARCH_SA1100 || ARCH_PXA || ARCH_S3C2410)
With the || AVR32 I've added to my version it's getting a bit out of
hand! Anyone else think it would be worth introducing a GPIO_FRAMEWORK
symbol selected by each machine which supports it and just set the
gpio_keys dependency to that?
Ben.
next prev parent reply other threads:[~2007-03-02 0:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-01 23:51 [patch 2.6.21-rc2] gpio_keys driver shouldn't be ARM-specific David Brownell
2007-03-02 0:18 ` Ben Nizette [this message]
2007-03-02 0:54 ` David Brownell
2007-03-02 2:21 ` Ben Nizette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E76D65.30405@iinet.net.au \
--to=ben.nizette@iinet.net.au \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=dtor@mail.ru \
--cc=hskinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.