From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zachary Amsden Subject: Re: [patch 12/26] Xen-paravirt_ops: Fix patch site clobbers to include return register Date: Thu, 01 Mar 2007 16:52:57 -0800 Message-ID: <45E77569.9010602@vmware.com> References: <20070301232443.195603797@goop.org> <20070301232527.755495278@goop.org> <45E7738D.5090607@vmware.com> <45E774AB.5090103@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <45E774AB.5090103@goop.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Fitzhardinge Cc: xen-devel@lists.xensource.com, virtualization@lists.osdl.org, Rusty Russell , linux-kernel@vger.kernel.org, Chris Wright , Andi Kleen , Andrew Morton List-Id: virtualization@lists.linuxfoundation.org Jeremy Fitzhardinge wrote: > Zachary Amsden wrote: > >> Jeremy Fitzhardinge wrote: >> >>> Fix a few clobbers to include the return register. The clobbers set >>> is the set of all registers modified (or may be modified) by the code >>> snippet, regardless of whether it was deliberate or accidental. >>> >>> Signed-off-by: Jeremy Fitzhardinge >>> Cc: Rusty Russell >>> Cc: Zachary Amsden >>> >>> --- >>> include/asm-i386/paravirt.h | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> =================================================================== >>> --- a/include/asm-i386/paravirt.h >>> +++ b/include/asm-i386/paravirt.h >>> @@ -556,7 +556,7 @@ static inline unsigned long __raw_local_ >>> "popl %%edx; popl %%ecx") >>> : "=a"(f): "m"(paravirt_ops.save_fl), >>> paravirt_type(PARAVIRT_PATCH(save_fl)), >>> - paravirt_clobber(CLBR_NONE) >>> + paravirt_clobber(CLBR_EAX) >>> : "memory", "cc"); >>> return f; >>> >>> >> Has this been tested on older gcc's? I seem to recall them barfing >> over things like this. >> > > Things like what? Do you mean the %[foo] asm parameter syntax? I think > those versions are no longer supported - Arjan posted a patch a few days > ago to convert a pile of asms to this form. Or do you mean something else? > I meant having an output in the clobber list, I didn't know we were dropping support for older versions already. Zach From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422665AbXCBAxA (ORCPT ); Thu, 1 Mar 2007 19:53:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1422666AbXCBAxA (ORCPT ); Thu, 1 Mar 2007 19:53:00 -0500 Received: from smtp-outbound-1.vmware.com ([65.113.40.141]:44667 "EHLO smtp-outbound-1.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422665AbXCBAw7 (ORCPT ); Thu, 1 Mar 2007 19:52:59 -0500 Message-ID: <45E77569.9010602@vmware.com> Date: Thu, 01 Mar 2007 16:52:57 -0800 From: Zachary Amsden User-Agent: Thunderbird 1.5.0.9 (X11/20061206) MIME-Version: 1.0 To: Jeremy Fitzhardinge CC: Andi Kleen , Andrew Morton , linux-kernel@vger.kernel.org, virtualization@lists.osdl.org, xen-devel@lists.xensource.com, Chris Wright , Rusty Russell Subject: Re: [patch 12/26] Xen-paravirt_ops: Fix patch site clobbers to include return register References: <20070301232443.195603797@goop.org> <20070301232527.755495278@goop.org> <45E7738D.5090607@vmware.com> <45E774AB.5090103@goop.org> In-Reply-To: <45E774AB.5090103@goop.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Jeremy Fitzhardinge wrote: > Zachary Amsden wrote: > >> Jeremy Fitzhardinge wrote: >> >>> Fix a few clobbers to include the return register. The clobbers set >>> is the set of all registers modified (or may be modified) by the code >>> snippet, regardless of whether it was deliberate or accidental. >>> >>> Signed-off-by: Jeremy Fitzhardinge >>> Cc: Rusty Russell >>> Cc: Zachary Amsden >>> >>> --- >>> include/asm-i386/paravirt.h | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> =================================================================== >>> --- a/include/asm-i386/paravirt.h >>> +++ b/include/asm-i386/paravirt.h >>> @@ -556,7 +556,7 @@ static inline unsigned long __raw_local_ >>> "popl %%edx; popl %%ecx") >>> : "=a"(f): "m"(paravirt_ops.save_fl), >>> paravirt_type(PARAVIRT_PATCH(save_fl)), >>> - paravirt_clobber(CLBR_NONE) >>> + paravirt_clobber(CLBR_EAX) >>> : "memory", "cc"); >>> return f; >>> >>> >> Has this been tested on older gcc's? I seem to recall them barfing >> over things like this. >> > > Things like what? Do you mean the %[foo] asm parameter syntax? I think > those versions are no longer supported - Arjan posted a patch a few days > ago to convert a pile of asms to this form. Or do you mean something else? > I meant having an output in the clobber list, I didn't know we were dropping support for older versions already. Zach