All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bill Davidsen <davidsen@tmr.com>
To: Neil Brown <neilb@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] md: Fix for raid6 reshape.
Date: Fri, 02 Mar 2007 15:34:24 -0500	[thread overview]
Message-ID: <45E88A50.8060906@tmr.com> (raw)
In-Reply-To: <17895.50900.585915.565155@notabene.brown>

Neil Brown wrote:
> On Thursday March 1, akpm@linux-foundation.org wrote:
>   
>> On Fri, 2 Mar 2007 15:56:55 +1100 NeilBrown <neilb@suse.de> wrote:
>>
>>     
>>> -	conf->expand_progress = (sector_nr + i)*(conf->raid_disks-1);
>>> +	conf->expand_progress = (sector_nr + i) * new_data_disks);
>>>       
>> ahem.
>>     
>
>
> It wasn't like that when I tested it, honest...
> But the original got caught up with some other changes which were not
> really related so I removed them all and just made this change
> manually.... and totally messed it up (again).  Sorry.
>
> Of course it should be
>
>   
>>> +	conf->expand_progress = (sector_nr + i) * new_data_disks;
>>>       
Will the (real) fix be in 2.6.21?

-- 
bill davidsen <davidsen@tmr.com>
  CTO TMR Associates, Inc
  Doing interesting things with small computers since 1979


  reply	other threads:[~2007-03-02 20:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070302155626.19014.patches@notabene>
2007-03-02  4:56 ` [PATCH] md: Fix for raid6 reshape NeilBrown
2007-03-02  6:36   ` Andrew Morton
2007-03-02  6:40     ` Neil Brown
2007-03-02 20:34       ` Bill Davidsen [this message]
2007-03-06  0:01         ` Neil Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45E88A50.8060906@tmr.com \
    --to=davidsen@tmr.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.