From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: implement and use ata_wait_idle_quiet()
Date: Fri, 02 Mar 2007 17:51:16 -0500 [thread overview]
Message-ID: <45E8AA64.9080207@garzik.org> (raw)
In-Reply-To: <20070227142606.GI20322@htj.dyndns.org>
Tejun Heo wrote:
> ata_wait_idle() complains when the device isn't idle 10ms wait.
> However, this function sometimes is used on empty ports. As SATA
> controllers report arbitrary status on empty ports, this causes
> spurious warning messages.
>
> * separate ata_wait_idle_quiet() from ata_wait_idle()
> * use _quiet version in ata_irq_on()
> * fix warning message in ata_wait_idle() to use ata_port_printk()
> while at it
>
> This makes spurious abnormal status messages seen in many sff
> controllers.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
My feeling is that this will also hide bugs, such as in the AHCI case
Jeff
next prev parent reply other threads:[~2007-03-02 22:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-27 14:26 [PATCH] libata: implement and use ata_wait_idle_quiet() Tejun Heo
2007-03-02 22:51 ` Jeff Garzik [this message]
2007-03-03 0:48 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E8AA64.9080207@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.