From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HNIG7-0005k4-LS
	for qemu-devel@nongnu.org; Fri, 02 Mar 2007 19:37:59 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1HNIG6-0005js-0n
	for qemu-devel@nongnu.org; Fri, 02 Mar 2007 19:37:58 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1HNIG5-0005jp-Sj
	for qemu-devel@nongnu.org; Fri, 02 Mar 2007 19:37:57 -0500
Received: from sp604001mt.neufgp.fr ([84.96.92.60] helo=Smtp.neuf.fr)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1HNIG5-0000oB-G7
	for qemu-devel@nongnu.org; Fri, 02 Mar 2007 19:37:57 -0500
Received: from [84.102.211.5] by sp604001mt.gpm.neuf.ld
	(Sun Java System Messaging Server 6.2-5.05 (built Feb 16 2006))
	with ESMTP id <0JEA000SLXR6NZH0@sp604001mt.gpm.neuf.ld> for
	qemu-devel@nongnu.org; Sat, 03 Mar 2007 01:37:54 +0100 (CET)
Date: Sat, 03 Mar 2007 01:38:17 +0100
From: Fabrice Bellard <fabrice@bellard.org>
Subject: Re: [Qemu-devel] [PATCH] pcnet32 driver change, please test
In-reply-to: <20070302202913.GE27636@networkno.de>
Message-id: <45E8C379.7040903@bellard.org>
MIME-version: 1.0
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: 7BIT
References: <20070302200949.GD27636@networkno.de>
	<20070302202913.GE27636@networkno.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Thiemo Seufer wrote:
> Thiemo Seufer wrote:
>> Hello All,
>>
>> I changed the pcnet32 driver to get rid of bitfields in its
>> implementation, now it works also on big endian host systems.
>>
>> I tested only the 32 bit mode which is used by MIPS/Malta, and
>> I'm not sure if it still works in Lance mode (as e.g. used on SPARC).
>> So please test if it still works.
> 
> I forgot to delete a line of debug output, updated.

It seems that you made some unnecessary changes (why did you changed the 
code in pcnet_init ?).

Regards,

Fabrice.