From: Jeff Garzik <jgarzik@pobox.com>
To: Dale Farnsworth <dale@farnsworth.org>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 1/2] mv643xx_eth: move mac_addr inside mv643xx_eth_platform_data
Date: Fri, 02 Mar 2007 20:17:16 -0500 [thread overview]
Message-ID: <45E8CC9C.3080607@pobox.com> (raw)
In-Reply-To: <20070301233148.GA19550@xyzzy.farnsworth.org>
Dale Farnsworth wrote:
> The information contained within platform_data should be self-contained.
> Replace the pointer to a MAC address with the actual MAC address in
> struct mv643xx_eth_platform_data.
>
> Signed-off-by: Dale Farnsworth <dale@farnsworth.org>
>
> ---
>
> Replaced explicit mac address comparison with a call to is_valid_ether_addr(),
> as suggested by Stephen Hemminger <shemminger@linux-foundation.org>.
>
> arch/mips/momentum/jaguar_atx/platform.c | 20 ++++----------------
> arch/mips/momentum/ocelot_3/platform.c | 20 ++++----------------
> arch/mips/momentum/ocelot_c/platform.c | 12 ++----------
> drivers/net/mv643xx_eth.c | 2 +-
> include/linux/mv643xx.h | 2 +-
> 5 files changed, 12 insertions(+), 44 deletions(-)
applied
prev parent reply other threads:[~2007-03-03 1:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-01 23:31 [PATCH 1/2] mv643xx_eth: move mac_addr inside mv643xx_eth_platform_data Dale Farnsworth
2007-03-01 23:33 ` [PATCH 2/2] mv643xx_eth: Place explicit port number in mv643xx_eth_platform_data Dale Farnsworth
2007-03-03 1:17 ` Jeff Garzik
2007-03-03 1:17 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E8CC9C.3080607@pobox.com \
--to=jgarzik@pobox.com \
--cc=dale@farnsworth.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.