From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HNn3F-0006U4-72
	for qemu-devel@nongnu.org; Sun, 04 Mar 2007 04:30:45 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1HNn3C-0006To-Jc
	for qemu-devel@nongnu.org; Sun, 04 Mar 2007 04:30:43 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1HNn3C-0006Tl-El
	for qemu-devel@nongnu.org; Sun, 04 Mar 2007 04:30:42 -0500
Received: from mis011-2.exch011.intermedia.net ([64.78.21.129])
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1HNn3C-0004DF-13
	for qemu-devel@nongnu.org; Sun, 04 Mar 2007 04:30:42 -0500
Message-ID: <45EA91BD.8030405@qumranet.com>
Date: Sun, 04 Mar 2007 11:30:37 +0200
From: Avi Kivity <avi@qumranet.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Add -name option
References: <45EA38D2.7050903@codemonkey.ws>
In-Reply-To: <45EA38D2.7050903@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Anthony Liguori wrote:
> This option helps differentiate between guests when running more than 
> one instance of QEMU.  It adds a string to the SDL window title and to 
> the VNC server title.
>
> Having a name associated with a guest is also terribly useful for 
> management tools as it gives a standard way to identify guests to the 
> user.
>
>  
> -    vnc_write_u32(vs, 4);        
> -    vnc_write(vs, "QEMU", 4);
> +    if (qemu_name) 
> +	size = snprintf(buf, sizeof(buf), "QEMU (%s)", qemu_name);
> +    else
> +	size = snprintf(buf, sizeof(buf), "QEMU");
> +

Perhaps in the modern style:

    snprintf("%s - QEMU", sizeof, qemu_name)

?

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.