All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sylvain Munaut <tnt@246tNt.com>
To: Domen Puncer <domen.puncer@telargo.com>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH alternative] lite5200(b) support for i2c
Date: Mon, 05 Mar 2007 11:24:46 +0100	[thread overview]
Message-ID: <45EBEFEE.9030309@246tNt.com> (raw)
In-Reply-To: <20070305100802.GV4397@moe.telargo.com>

Domen Puncer wrote:
> Add fsl-i2c to lite5200 i2c nodes in device tree, and enable FSL_SOC.
>
> Tested to work with built-in eeprom on lite5200b.
>
>
> Signed-off-by: Domen Puncer <domen.puncer@telargo.com>
>
> ---
> This patch obsoletes the previous one, and is shorter too :-)
>
>
>  arch/powerpc/Kconfig                |    1 +
>  arch/powerpc/boot/dts/lite5200.dts  |    6 ++++--
>  arch/powerpc/boot/dts/lite5200b.dts |    6 ++++--
>  3 files changed, 9 insertions(+), 4 deletions(-)
>
> Index: grant.git/arch/powerpc/Kconfig
> ===================================================================
> --- grant.git.orig/arch/powerpc/Kconfig
> +++ grant.git/arch/powerpc/Kconfig
> @@ -128,6 +128,7 @@ config CLASSIC32
>  	bool "52xx/6xx/7xx/74xx"
>  	select PPC_FPU
>  	select 6xx
> +	select FSL_SOC
>  	help
>  	  There are four families of PowerPC chips supported.  The more common
>  	  types (601, 603, 604, 740, 750, 7400), the Motorola embedded
>
>   
I would put the select FSL_SOC under the  PPC_MPC52xx symbol and not the
CLASSIC32 one.
Otherwise, looks good.

    Sylvain

  reply	other threads:[~2007-03-05 10:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-02 10:47 [PATCH] i2c-mpc: add support for arch/powerpc/ tree Domen Puncer
2007-03-05 10:08 ` [PATCH alternative] lite5200(b) support for i2c Domen Puncer
2007-03-05 10:24   ` Sylvain Munaut [this message]
2007-03-05 10:40     ` [PATCH try3] " Domen Puncer
2007-03-05 10:53       ` Sylvain Munaut
2007-03-05 14:53         ` Kumar Gala
2007-03-05 14:55           ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45EBEFEE.9030309@246tNt.com \
    --to=tnt@246tnt.com \
    --cc=domen.puncer@telargo.com \
    --cc=linuxppc-embedded@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.