From: Eric Dumazet <dada1@cosmosbay.com>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch] epoll use a single inode ...
Date: Mon, 05 Mar 2007 22:52:41 +0100 [thread overview]
Message-ID: <45EC9129.7050903@cosmosbay.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0703051311380.4907@alien.or.mcafeemobile.com>
Davide Libenzi a écrit :
> * using the inode number.
> */
> error = -ENOMEM;
> - sprintf(name, "[%lu]", inode->i_ino);
> + sprintf(name, "[%p]", ep);
> this.name = name;
> this.len = strlen(name);
Small remark : you can avoid strlen(), since sprintf gives you the value :)
this.len = sprintf(name, "[%p]", ep);
Also, your patch description is not complete : you forgot to say that epoll
dentries are not anymore hashed into global dcache hashtable :)
next prev parent reply other threads:[~2007-03-05 21:53 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-05 21:25 [patch] epoll use a single inode Davide Libenzi
2007-03-05 21:52 ` Eric Dumazet [this message]
[not found] <45ED046A.5010508@argo.co.il>
2007-03-06 7:27 ` Davide Libenzi
[not found] <45ED1A3C.6030707@argo.co.il>
2007-03-07 0:37 ` Davide Libenzi
2007-03-07 0:51 ` Linus Torvalds
2007-03-07 1:01 ` Davide Libenzi
2007-03-07 1:27 ` Linus Torvalds
2007-03-07 1:47 ` Davide Libenzi
2007-03-07 6:52 ` Eric Dumazet
2007-03-07 7:15 ` Davide Libenzi
2007-03-07 7:16 ` Eric Dumazet
2007-03-07 8:56 ` Christoph Hellwig
2007-03-07 17:21 ` Linus Torvalds
2007-03-07 17:02 ` Linus Torvalds
2007-03-07 17:31 ` Eric Dumazet
2007-03-07 17:36 ` Eric Dumazet
2007-03-07 17:45 ` Linus Torvalds
2007-03-07 18:06 ` Eric Dumazet
2007-03-07 18:30 ` Linus Torvalds
2007-03-07 18:52 ` Eric Dumazet
2007-03-07 19:07 ` Linus Torvalds
2007-03-07 22:14 ` Anton Blanchard
2007-03-07 22:57 ` Linus Torvalds
2007-03-08 1:25 ` Michael K. Edwards
2007-03-08 2:48 ` Kyle Moffett
2007-03-08 7:24 ` Eric Dumazet
2007-03-08 16:57 ` Valdis.Kletnieks
2007-03-09 1:34 ` Kyle Moffett
2007-03-09 2:52 ` Anton Blanchard
2007-03-09 2:51 ` Anton Blanchard
2007-03-08 3:20 ` Linus Torvalds
2007-03-08 8:37 ` Michael K. Edwards
2007-03-09 2:46 ` Anton Blanchard
2007-03-08 8:56 ` Christoph Hellwig
2007-03-08 9:42 ` Eric Dumazet
2007-03-08 10:21 ` Christoph Hellwig
2007-03-08 11:11 ` Eric Dumazet
2007-03-08 11:18 ` Christoph Hellwig
2007-03-08 15:52 ` Linus Torvalds
2007-03-08 20:00 ` Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45EC9129.7050903@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=akpm@linux-foundation.org \
--cc=davidel@xmailserver.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.