From: "H. Peter Anvin" <hpa@zytor.com>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Eric Dumazet <dada1@cosmosbay.com>
Subject: Re: [patch v2] epoll use a single inode ...
Date: Mon, 05 Mar 2007 18:37:08 -0800 [thread overview]
Message-ID: <45ECD3D4.5020305@zytor.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0703051832260.4907@alien.or.mcafeemobile.com>
Davide Libenzi wrote:
>
> Right now is using:
>
> this.len = sprintf(name, "[%u.%d]", current->pid, fd);
>
> That should be unique and not have the wraparound problem. Ack?
>
NAK, very much NAK.
File descriptors aren't file structures, they're *pointers* to file
structures.
It's perfectly possible -- downright common -- for a file descriptor to
be inherited by another process, and then the pid is recycled -- collision.
-hpa
next prev parent reply other threads:[~2007-03-06 2:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-05 23:41 [patch v2] epoll use a single inode Davide Libenzi
2007-03-06 0:00 ` Linus Torvalds
2007-03-06 0:12 ` Davide Libenzi
2007-03-06 0:20 ` Davide Libenzi
2007-03-06 0:25 ` Linus Torvalds
2007-03-06 2:25 ` H. Peter Anvin
2007-03-06 2:34 ` Davide Libenzi
2007-03-06 2:37 ` H. Peter Anvin [this message]
2007-03-06 2:43 ` Davide Libenzi
2007-03-06 6:22 ` Eric Dumazet
2007-03-06 6:31 ` Davide Libenzi
2007-03-06 6:37 ` Davide Libenzi
2007-03-06 16:28 ` H. Peter Anvin
2007-03-06 17:09 ` Linus Torvalds
2007-03-06 17:14 ` H. Peter Anvin
2007-03-06 17:12 ` Eric Dumazet
2007-03-06 17:19 ` Linus Torvalds
2007-03-06 17:27 ` H. Peter Anvin
2007-03-06 17:28 ` Eric Dumazet
2007-03-06 18:10 ` Eric Dumazet
2007-03-06 20:20 ` Eric Dumazet
2007-03-07 3:47 ` Linus Torvalds
2007-03-07 5:40 ` H. Peter Anvin
2007-03-07 6:57 ` Eric Dumazet
2007-03-07 7:13 ` H. Peter Anvin
2007-03-07 23:46 ` Sami Farin
2007-03-06 18:10 ` Davide Libenzi
2007-03-10 8:06 ` Pavel Machek
2007-03-10 8:24 ` Davide Libenzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45ECD3D4.5020305@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=dada1@cosmosbay.com \
--cc=davidel@xmailserver.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.