All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Yang <leoli@freescale.com>
To: junkio@cox.net
Cc: git@vger.kernel.org, jnareb@gmail.com
Subject: [PATCH] gitweb: Change to use explicitly function call cgi->escapHTML()
Date: Tue, 06 Mar 2007 11:58:56 +0800	[thread overview]
Message-ID: <45ECE700.8090205@freescale.com> (raw)

Change to use explicitly function call cgi->escapHTML().
This fix the problem on some systems that escapeHTML() is not
functioning, as default CGI is not setting 'escape' parameter.

Signed-off-by: Li Yang <leoli@freescale.com>

---
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 653ca3c..3a564d1 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -591,7 +591,7 @@ sub esc_html ($;%) {
 	my %opts = @_;
 
 	$str = to_utf8($str);
-	$str = escapeHTML($str);
+	$str = $cgi->escapeHTML($str);
 	if ($opts{'-nbsp'}) {
 		$str =~ s/ /&nbsp;/g;
 	}
@@ -605,7 +605,7 @@ sub esc_path {
 	my %opts = @_;
 
 	$str = to_utf8($str);
-	$str = escapeHTML($str);
+	$str = $cgi->escapeHTML($str);
 	if ($opts{'-nbsp'}) {
 		$str =~ s/ /&nbsp;/g;
 	}

             reply	other threads:[~2007-03-06  3:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-06  3:58 Li Yang [this message]
2007-03-06  6:55 ` [PATCH] gitweb: Change to use explicitly function call cgi->escapHTML() Junio C Hamano
2007-03-06  9:34   ` Jakub Narebski
2007-03-06  9:39     ` Jeff King
2007-03-06  9:46       ` Junio C Hamano
2007-03-06 10:31       ` Li Yang-r58472
2007-03-06 10:41         ` Jeff King
2007-03-06 10:53           ` Junio C Hamano
2007-03-06 10:56             ` Jeff King
2007-03-06 10:58               ` Junio C Hamano
2007-03-06 11:01                 ` Jeff King
2007-03-06 11:05                   ` Junio C Hamano
2007-03-06 11:07                     ` Jeff King
2007-03-06 11:07                   ` Li Yang-r58472
2007-03-06 10:45         ` Junio C Hamano
2007-03-06 13:23           ` Jakub Narebski
2007-03-06 23:17             ` Junio C Hamano
2007-03-07  0:37               ` Jakub Narebski
2007-03-07  0:49                 ` Junio C Hamano
2007-03-07  1:21                   ` [PATCH] gitweb: Don't escape attributes in CGI.pm HTML methods Jakub Narebski
2007-03-07  1:40                     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45ECE700.8090205@freescale.com \
    --to=leoli@freescale.com \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.