From: Sylvain Munaut <tnt@246tNt.com>
To: Domen Puncer <domen.puncer@telargo.com>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH] mpc52xx_pic: fix main interrupt masking
Date: Tue, 06 Mar 2007 11:02:17 +0100 [thread overview]
Message-ID: <45ED3C29.6020100@246tNt.com> (raw)
In-Reply-To: <20070306095011.GY4397@moe.telargo.com>
Domen Puncer wrote:
> Fix main interrupt masking.
> Tested with RTC and GPIO_WKUP interrupts.
>
>
> Signed-off-by: Domen Puncer <domen.puncer@telargo.com>
>
Acked-by: Sylvain Munaut <tnt@246tNt.com>
Damn, I knew I forgot something during the last batch ! That bug had
already been spotted earlier ...
> ---
> arch/powerpc/platforms/52xx/mpc52xx_pic.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: grant.git/arch/powerpc/platforms/52xx/mpc52xx_pic.c
> ===================================================================
> --- grant.git.orig/arch/powerpc/platforms/52xx/mpc52xx_pic.c
> +++ grant.git/arch/powerpc/platforms/52xx/mpc52xx_pic.c
> @@ -128,7 +128,7 @@ static void mpc52xx_main_mask(unsigned i
>
> pr_debug("%s: irq=%x. l2=%d\n", __func__, irq, l2irq);
>
> - io_be_setbit(&intr->main_mask, 15 - l2irq);
> + io_be_setbit(&intr->main_mask, 16 - l2irq);
> }
>
> static void mpc52xx_main_unmask(unsigned int virq)
> @@ -141,7 +141,7 @@ static void mpc52xx_main_unmask(unsigned
>
> pr_debug("%s: irq=%x. l2=%d\n", __func__, irq, l2irq);
>
> - io_be_clrbit(&intr->main_mask, 15 - l2irq);
> + io_be_clrbit(&intr->main_mask, 16 - l2irq);
> }
>
> static struct irq_chip mpc52xx_main_irqchip = {
> _______________________________________________
> Linuxppc-embedded mailing list
> Linuxppc-embedded@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-embedded
>
>
prev parent reply other threads:[~2007-03-06 10:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 9:50 [PATCH] mpc52xx_pic: fix main interrupt masking Domen Puncer
2007-03-06 10:02 ` Sylvain Munaut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45ED3C29.6020100@246tNt.com \
--to=tnt@246tnt.com \
--cc=domen.puncer@telargo.com \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.