From: Jeff Garzik <jeff@garzik.org>
To: Don Fry <pcnet32@verizon.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] pcnet32: only allocate init_block dma consistent
Date: Tue, 06 Mar 2007 06:13:14 -0500 [thread overview]
Message-ID: <45ED4CCA.7030606@garzik.org> (raw)
In-Reply-To: <20070306021037.GA7139@verizon.net>
Don Fry wrote:
> The patch below moves the init_block out of the private struct and
> only allocates init block with pci_alloc_consistent.
>
> This has two effects:
>
> 1. Performance increase for non cache coherent machines, because the
> CPU only data in the private struct are now cached
>
> 2. locks are working now for platforms, which need to have locks
> in cached memory
>
> Also use netdev_priv() instead of dev->priv
>
> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
please separate the netdev_priv() change into a separate, precursor
patch, and resend both
next prev parent reply other threads:[~2007-03-06 11:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 2:10 [PATCH] pcnet32: only allocate init_block dma consistent Don Fry
2007-03-06 11:13 ` Jeff Garzik [this message]
2007-03-06 18:30 ` Don Fry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45ED4CCA.7030606@garzik.org \
--to=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=pcnet32@verizon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.