From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Thomas Graf <tgraf@suug.ch>
Cc: Netfilter Development Mailinglist
<netfilter-devel@lists.netfilter.org>,
Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH 4/7 parse attributes with nfattr_parse in nfnetlink_check_attribute
Date: Wed, 07 Mar 2007 11:43:32 +0100 [thread overview]
Message-ID: <45EE9754.8040304@netfilter.org> (raw)
In-Reply-To: <20070306214527.GD521@postel.suug.ch>
Thomas Graf wrote:
> * Patrick McHardy <kaber@trash.net> 2007-02-13 12:05
>> Pablo Neira Ayuso wrote:
>> Currently other netlink subsystems return errors for the first level
>> of attributes and accept unknown attributes on deeper levels. I'm
>> not sure which I prefer, ignoring unknown attributes makes it
>> impossible for userspace to know that something isn't going to have
>> any effect, returning an error makes it harder to support new features.
>>
>> I know Thomas had intentions of increasing consistency in this area,
>> I'm just not sure in which direction :)
>>
>> Thomas, what do you think of this patch?
>
> I believe that all unknown attributes should be ignored so recent
> userspace code can function on older kernels. That's the way I'm
> working towards.
Then I'll resend the patch if nobody objects anymore ;)
--
The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris
next prev parent reply other threads:[~2007-03-07 10:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-12 22:46 [PATCH 4/7 parse attributes with nfattr_parse in nfnetlink_check_attribute Pablo Neira Ayuso
2007-02-13 11:05 ` Patrick McHardy
2007-03-06 21:45 ` Thomas Graf
2007-03-07 10:43 ` Pablo Neira Ayuso [this message]
2007-03-14 8:23 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45EE9754.8040304@netfilter.org \
--to=pablo@netfilter.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@lists.netfilter.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.