From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] get rid of fname[] for tracing functions
Date: Wed, 07 Mar 2007 08:34:50 -0600 [thread overview]
Message-ID: <45EECD8A.7000503@sandeen.net> (raw)
In-Reply-To: <20070307082753.GA5469@infradead.org>
Christoph Hellwig wrote:
>> the vn tracing could probably get a similar treatment, so that every
>> call to vn_trace_foo wouldn't have to include a function name and a
>> __builtin_return_address, but could be done via macros... it's currently
>> a mishmash of __FUNCTION__ and "function" *shrug* what do you think?
>
> It should probably use __FUNCTION__ and hide use of both __FUNCTION__
> and __builtin_return_address behind a macro.
>
Yep, that's exactly what I meant, I've started a patch to do that too.
-Eric
next prev parent reply other threads:[~2007-03-07 14:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-07 3:18 [PATCH] get rid of fname[] for tracing functions Eric Sandeen
2007-03-07 8:27 ` Christoph Hellwig
2007-03-07 14:34 ` Eric Sandeen [this message]
2007-03-17 2:27 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45EECD8A.7000503@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.