From: Mark Lord <lkml@rtr.ca>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] prism54usb: Fix hail of warnings on 64bit platforms
Date: Wed, 07 Mar 2007 10:42:57 -0500 [thread overview]
Message-ID: <45EEDD81.4080301@rtr.ca> (raw)
In-Reply-To: <20070307164020.16944e32@lxorguk.ukuu.org.uk>
Alan Cox wrote:
> If you want to cast a pointer to a small value then start by turning it
> into an unsigned long so the compiler knows what is going on.
>
> Personally I find the whole approach used by this driver for types of
> registers (which are really USB register numbers) utterly perverse...
...
>
> err = p54u_write(priv, buf, type,\
> - cpu_to_le32((u32)addr), data);\
> + cpu_to_le32((u32)(unsigned long)addr), data);\
...
What exactly are those "addr" parameters -- memory addresses ?
-ml
next prev parent reply other threads:[~2007-03-07 15:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-07 16:40 [PATCH] prism54usb: Fix hail of warnings on 64bit platforms Alan Cox
2007-03-07 15:42 ` Mark Lord [this message]
2007-03-07 17:00 ` Alan Cox
2007-03-07 17:21 ` Michael Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45EEDD81.4080301@rtr.ca \
--to=lkml@rtr.ca \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.