From: Dave Jiang <djiang@mvista.com>
To: Andi Kleen <ak@suse.de>
Cc: linux-kernel@vger.kernel.org, trini@kernel.crashing.org,
sshtylyov@ru.mvista.com
Subject: Re: [PATCH] x86_64 RESTORE_CONTEXT missing '\n'
Date: Thu, 08 Mar 2007 10:44:14 -0700 [thread overview]
Message-ID: <45F04B6E.9000703@mvista.com> (raw)
In-Reply-To: <200703081814.53153.ak@suse.de>
Andi Kleen wrote:
> On Wednesday 07 March 2007 21:45, Dave Jiang wrote:
>> The RESTORE_CONTEXT macro is missing the '\n' at the end. It was removed in the
>> previous patch that touched system.h. It causes compile failure if any
>> inline asm is added after the macro. Discovered this when playing with
>> kgdb.
>
> We went through this several times. kgdb has no business to poke
> into kernel private macros like this and it shouldn't do that.
> So fixing kgdb to not require touching the context switch is the right
> change.
>
> -Andi
In spite of kgdb, shouldn't it have that \n anyways in case some other code
gets added in the future after the macro? Or are you saying that there should
never be any code ever after that macro?
--
------------------------------------------------------
Dave Jiang
Software Engineer
MontaVista Software, Inc.
http://www.mvista.com
------------------------------------------------------
next prev parent reply other threads:[~2007-03-08 17:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-07 20:45 [PATCH] x86_64 RESTORE_CONTEXT missing '\n' Dave Jiang
2007-03-08 17:14 ` Andi Kleen
2007-03-08 17:44 ` Dave Jiang [this message]
2007-03-08 18:37 ` Andi Kleen
2007-03-08 18:49 ` Tom Rini
2007-03-08 22:24 ` Permanent Kgdb integration into the kernel - lets get with it Piet Delaney
2007-04-17 18:30 ` Randy Dunlap
2007-04-17 18:37 ` Sergei Shtylyov
2007-04-17 18:42 ` Randy Dunlap
2007-04-17 18:45 ` Sergei Shtylyov
2007-04-17 18:45 ` Andi Kleen
2007-04-20 16:20 ` Robin Holt
2007-04-20 22:51 ` Piet Delaney
2007-04-20 23:34 ` Andrew Morton
2007-04-21 9:48 ` Andi Kleen
2007-04-24 4:02 ` Permanent Kgdb integration into the kernel - lets get with it. (Dave: How do FreeBSD folks maintain the KGDB stub?) Piet Delaney
2007-03-08 22:36 ` [PATCH] x86_64 RESTORE_CONTEXT missing '\n' Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F04B6E.9000703@mvista.com \
--to=djiang@mvista.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.