From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jambunathan K <jambunathan@netxen.com>
Subject: pciback_field_is_dup needs a fix
Date: Fri, 09 Mar 2007 01:09:19 +0530
Message-ID: <45F06667.8080705@netxen.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
Cc: sanjeev@netxen.com
List-Id: xen-devel@lists.xenproject.org

Shouldn't pciback_field_is_dup(dev, field->offset) be scoped to include 
the base_offset as well?

Currently with xen-3.0.4 the issue is this:

Adding of  PCI_PM_CTRL (at offset 4)  to the 'config_fields list' gets 
skipped because it ends up being a duplicate of PCI_COMMAND (at offset 4 
as well).  As a result when a PCI device behind a PCI frontend does a 
power up using pci_enable_device() the following message gets flashed on 
the console.

pciback 0000:0b:00.3: Driver tried to write to a read-only configuration 
space field at offset 0x84, size 2. This may be harmless, but if you 
have problems with your device:
1) see permissive attribute in sysfs
2) report problems to the xen-devel mailing list along with details of 
your device obtained from lspci.

Thanks,
Jambunathan K.