From: Jeff Garzik <jgarzik@pobox.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: akpm@osdl.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata_piix: Remove ugly layering violation
Date: Fri, 09 Mar 2007 07:29:42 -0500 [thread overview]
Message-ID: <45F15336.9040707@pobox.com> (raw)
In-Reply-To: <20070307161307.37b1e36f@lxorguk.ukuu.org.uk>
Alan Cox wrote:
> A while ago I modified the libata code so that drivers can return -ENOENT
> for unknown ports not fiddle with the EH flags and print stuff directly.
> Somewhere along the line ata_piix didn't get fully converted.
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.21-rc2-mm2/drivers/ata/ata_piix.c linux-2.6.21-rc2-mm2/drivers/ata/ata_piix.c
> --- linux.vanilla-2.6.21-rc2-mm2/drivers/ata/ata_piix.c 2007-03-06 23:09:46.000000000 +0000
> +++ linux-2.6.21-rc2-mm2/drivers/ata/ata_piix.c 2007-03-06 23:33:53.000000000 +0000
will apply this in the next few hours
> #define DRV_NAME "ata_piix"
> -#define DRV_VERSION "2.10"
> +#define DRV_VERSION "2.10ac1"
please don't add "acX" suffixes. that's like spraypainting "alan wuz
here" graphitti ;-) Just increment to the next numeric version, like
you do with the other PATA drivers.
Jeff
next prev parent reply other threads:[~2007-03-09 12:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-07 16:13 [PATCH] ata_piix: Remove ugly layering violation Alan Cox
2007-03-09 12:29 ` Jeff Garzik [this message]
2007-03-09 14:06 ` Alan Cox
2007-03-09 12:38 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F15336.9040707@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.