From: Jeff Garzik <jgarzik@pobox.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: akpm@osdl.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] pata_sis: Clean up using cable_detect methods
Date: Fri, 09 Mar 2007 07:32:52 -0500 [thread overview]
Message-ID: <45F153F4.8010903@pobox.com> (raw)
In-Reply-To: <20070307165424.5e770840@lxorguk.ukuu.org.uk>
Alan Cox wrote:
> This changeset revolves around the fact that all the SiS controllers have
> the same enable bits, but differing cable detection methods. Previously
> that meant each type had its own error_handler methods. Instead we can
> now implement different ->cable_detect methods and share a single
> error_handler which does the filtering by enable bits.
>
> In addition we had some auto const arrays that should be static const. I'm
> not sure if gcc already treats them intelligently but adding the static
> will make sure.
>
> Signed-off-by: Alan Cox <alan@redhat.com>
applied (patch dated mar 07)
prev parent reply other threads:[~2007-03-09 12:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-07 16:54 [PATCH] pata_sis: Clean up using cable_detect methods Alan Cox
2007-03-09 12:32 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F153F4.8010903@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.