From: Jeff Garzik <jeff@garzik.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-ide@vger.kernel.org
Subject: Re: [PATCH]: libata-core: Add support for ATA_HORKAGE_DIAGNOSTIC
Date: Fri, 09 Mar 2007 07:48:01 -0500 [thread overview]
Message-ID: <45F15781.7090402@garzik.org> (raw)
In-Reply-To: <20070308231804.110f76a0@lxorguk.ukuu.org.uk>
Alan Cox wrote:
> If we find the device has broken diagnostics then don't report this if we
> expect it to. Needed for the Gigabyte i-RAM.
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.21-rc3-mm2/drivers/ata/libata-core.c linux-2.6.21-rc3-mm2/drivers/ata/libata-core.c
> --- linux.vanilla-2.6.21-rc3-mm2/drivers/ata/libata-core.c 2007-03-08 16:01:10.000000000 +0000
> +++ linux-2.6.21-rc3-mm2/drivers/ata/libata-core.c 2007-03-08 16:02:52.000000000 +0000
> @@ -1751,7 +1765,7 @@
> /* Let the user know. We don't want to disallow opens for
> rescue purposes, or in case the vendor is just a blithering
> idiot */
> - if (print_info) {
> + if (print_info && !(ata_device_blacklisted(dev) & ATA_HORKAGE_DIAGNOSTIC)) {
> ata_dev_printk(dev, KERN_WARNING,
> "Drive reports diagnostics failure. This may indicate a drive\n");
> ata_dev_printk(dev, KERN_WARNING,
I don't understand this one at all.
The original point of the message was to poke people so that they poke
their vendors into fixing the firmware, which is indeed non-spec. I
would rather not silence a "your device is operating out-of-spec" warning.
Jeff
next prev parent reply other threads:[~2007-03-09 12:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-08 23:18 [PATCH]: libata-core: Add support for ATA_HORKAGE_DIAGNOSTIC Alan Cox
2007-03-09 12:48 ` Jeff Garzik [this message]
2007-03-09 14:03 ` Alan Cox
2007-03-09 13:05 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F15781.7090402@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.