Re: [PATCH 2/5] NetXen: Update the statistics counter for interrupts

[Stephen Hemminger <shemminger@linux-foundation.org>]

Linsys Contractor Mithlesh Thukral wrote:
> NetXen: Update the statistics counter for interrupts which have occured.
>
> Signed-off-by: Mithlesh Thukral <mithlesh@netxen.com>
> ---
>
>  drivers/net/netxen/netxen_nic_main.c |    1 +
>  1 files changed, 1 insertion(+)
>
> diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
> index bfeca9a..5fbf6b0 100644
> --- a/drivers/net/netxen/netxen_nic_main.c
> +++ b/drivers/net/netxen/netxen_nic_main.c
> @@ -1023,6 +1023,7 @@ netxen_handle_int(struct netxen_adapter 
>  	u32 ret = 0;
>  
>  	DPRINTK(INFO, "Entered handle ISR\n");
> +	adapter->stats.ints++;
>  
>   
You may want to consider the cost of the additional cache miss.
Either don't bother with this stat, or go to per-cpu stats.
Plus isn't this already in the statistics kept for /proc/interrupts?