Re: [PATCH 0/5] keyword driven parsing

[Josh Triplett <josh@freedesktop.org>]

[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]

Christopher Li wrote:
> On Wed, Mar 07, 2007 at 10:55:07PM -0800, Josh Triplett wrote:
>> Christopher Li wrote:
>>
>> Beautiful!  Looks far more elegant and maintainable; thanks.
>>
>> I've applied the first four patches in this series.  The fifth causes a
>> regression in validation/context.c; see the attached diff of the output from
>> the fourth to the fifth patches.
> 
> Hah. I misunderstand the syntax of context with only two arguments.
> This syntax sucks. The meaning of the each argument depends on the total
> number of arguments.

Guilty. :) I had to keep the two-argument version for backward compatibility,
but I still wanted what I considered a more intuitive argument order for the
new three-argument version.  Think of the two-argument version as deprecated.

> The patch is updated.
>
> Chris
> 
> Introduce keyword driven attribute parsing
> 
> Now we are really parsing the attribute rather than building the
> expression tree first.
> 
> Signed-Off-By: Christopher Li <sparse@chrisli.org>

Thanks, applied.

- Josh Triplett


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]