From: Larry Finger <larry.finger@lwfinger.net>
To: Joseph Jezak <josejx@gentoo.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-wireless@vger.kernel.org, Michael Buesch <mb@bu3sch.de>,
Bcm43xx-dev@lists.berlios.de
Subject: Re: [PATCH] bcm43xx: Fix typo in B5PHY init specifications
Date: Mon, 12 Mar 2007 13:48:33 -0500 [thread overview]
Message-ID: <45F5A081.1060800@lwfinger.net> (raw)
In-Reply-To: <45F55452.3000704@gentoo.org>
Joe,
Joseph Jezak wrote:
> David Woodhouse wrote:
>> On Fri, 2007-03-02 at 11:30 -0600, Larry Finger wrote:
>>> There was an error in the B5PHY init specifications.
>> This patch doesn't fix the machine check in bcm43xx_phy_initb5 which
>> Pavel Roskin and I reported a couple of weeks ago. To get rid of that
>> crash, I still have to revert an earlier 'spec update' patch
>> (740ac4fb08866d702be90f167665d03759bd27d0).
>>
>
> Yeah, the issue is that the Rev1 cards have to be init'd with g mode
> off. I'm not sure anyone has picked up this fix yet. The relevant
> spec fix is here: http://bcm-v4.sipsolutions.net/802.11/PHY/calinit
I think the bug may be even deeper. In bcm43xx_phy_connect, the G Mode Enable bit of TM State Low is
only written for phy->rev >= 5. I have not found any other place where that bit is set. From what I
read in the specs, that bit should exist and be set for all G PHY's. Is that correct? I think I'm
beginning to understand the confusion between phy->connected in the code and gmode in the specs.
Larry
prev parent reply other threads:[~2007-03-12 18:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-02 17:30 [PATCH] bcm43xx: Fix typo in B5PHY init specifications Larry Finger
2007-03-12 7:53 ` David Woodhouse
2007-03-12 13:23 ` Joseph Jezak
2007-03-12 14:53 ` John W. Linville
2007-03-12 15:16 ` David Woodhouse
2007-03-12 17:42 ` Larry Finger
2007-03-12 17:48 ` John W. Linville
2007-03-12 18:30 ` Larry Finger
2007-03-12 17:46 ` John W. Linville
2007-03-12 18:48 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F5A081.1060800@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=Bcm43xx-dev@lists.berlios.de \
--cc=dwmw2@infradead.org \
--cc=josejx@gentoo.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.