All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: "Zhai, Edwin" <edwin.zhai@intel.com>
Cc: Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk>, xen-devel@lists.xensource.com
Subject: Re: vram_dirty vs. shadow paging dirty tracking
Date: Wed, 14 Mar 2007 11:00:17 -0500	[thread overview]
Message-ID: <45F81C11.1020404@us.ibm.com> (raw)
In-Reply-To: <20070314082210.GX12238@edwin-srv.sh.intel.com>

Zhai, Edwin wrote:
> On Tue, Mar 13, 2007 at 02:32:56PM -0500, Anthony Liguori wrote:
>   
>> When thinking about multithreading the device model, it occurred to me 
>> that it's a little odd that we're doing a memcmp to determine which 
>> portions of the VRAM has changed.  Couldn't we just use dirty page 
>>     
>
> we made this code to improve the user vnc responsiveness long before.
> now QEMU has new vnc implementation to resolve this issue and this code 
> introduce perf drop for guest of linux with X or windows.
>   

Compared to what, just updating the full screen 30 times a second?  I 
suspect that's not as bad as it sounds since SDL will be using a XShmImage.

The VNC minimization is done based on a timer however so sticking the 
timer stuff into a thread is still useful.  Of course, we should be able 
to quickly determine how useful this is by just changing SDL to update 
the whole image...

Regards,

Anthony Liguori

> so i'd like to send a patch to revert it and make a proper solution in future.
>
> thanks,
>
>   
>> tracking in the shadow paging code?  That should significantly lower the 
>> overhead of this plus I believe the infrastructure is already mostly 
>> there in the shadow2 code.
>>
>> Is this a sane idea?
>>
>> Regards,
>>
>> Anthony Liguori
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xensource.com
>> http://lists.xensource.com/xen-devel
>>
>>     
>
>   

  reply	other threads:[~2007-03-14 16:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-13 19:32 vram_dirty vs. shadow paging dirty tracking Anthony Liguori
2007-03-13 21:02 ` Ian Pratt
2007-03-13 21:30   ` Anthony Liguori
2007-03-14  0:17     ` Ian Pratt
2007-03-14  8:22 ` Zhai, Edwin
2007-03-14 16:00   ` Anthony Liguori [this message]
2007-03-15  2:59     ` Zhai, Edwin
2007-03-15  3:22     ` Dong, Eddie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45F81C11.1020404@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=edwin.zhai@intel.com \
    --cc=m+Ian.Pratt@cl.cam.ac.uk \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.