From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?w4lyaWMgUGllbA==?= Subject: Re: [PATCH 0/2] wistron_btns: More keymaps Date: Wed, 14 Mar 2007 20:12:10 +0100 Message-ID: <45F8490A.6000807@tremplin-utc.net> References: <45ECA23A.5010503@tremplin-utc.net> <45ED8809.70309@tremplin-utc.net> <45F72D37.6090004@tremplin-utc.net> <20070314182559.GC5264@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: Dmitry Torokhov Cc: Vojtech Pavlik , mitr@volny.cz, otauber@web.de, linux-kernel@vger.kernel.org, linux-input List-Id: linux-input@vger.kernel.org 03/14/2007 08:02 PM, Dmitry Torokhov wrote/a =C3=A9crit: > On 3/14/07, Dmitry Torokhov wrote: >> On 3/14/07, Vojtech Pavlik wrote: >> > On Wed, Mar 14, 2007 at 09:54:27AM -0400, Dmitry Torokhov wrote: >> > > Hi Eric, >> > > >> > > 2. I also have a concern about using KEY_SCREEN to signal toggling >> > > display on and off. I am CCing Vojtech - he must know what the >> > > original intent of this key code was. BTW, when user presses >> > > corresponding button - does the display actually goes off? Maybe w= e >> > > need another switch. >> > >> > Sorry, Dmitry, I probably should have documented it back then, I don= 't >> > have the slightest idea anymore. >> > >> >> That's what I was afraid of ;) Well, maybe we should just use it to >> indicate display switch and add a comment to that effect to input.h... >> >=20 > Oh, wait, DVB uses this code to request switchin full screen mode, we > better not touch it. >=20 Isn't that what is supposed to do KEY_SWITCHVIDEOMODE? Humm... I've got=20 a feeling that it's not clear where the documentation is or that=20 documentation is missing ;-) IIRC, about a month ago someone already asked for precision on the=20 meaning of some KEY_* . It would probably worth documenting more each=20 key. More specifically, it could be interesting to decide if the keycode=20 has to be associated to the physical symbol displayed on the key or=20 associated to the function that the user (developer) expects when=20 pressing this key. Eric