From: Larry Finger <larry.finger@lwfinger.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [RFC] Eliminate some 'G Mode Enable' magic numbers
Date: Wed, 14 Mar 2007 15:04:22 -0500 [thread overview]
Message-ID: <45F85546.1010902@lwfinger.net> (raw)
In-Reply-To: <20070314194950.GG3372@tuxdriver.com>
John W. Linville wrote:
> On Wed, Mar 14, 2007 at 11:18:28AM -0500, Larry Finger wrote:
>> In code manipulating the TM State Low register of 802.11 cores, two
>> different magic numbers are used to reference the 'G Mode Enable' bit.
>> One of these, 0x20000000, is clear, but the other, (0x800 << 18), is not.
>> This patch replaces both types with a defined constant. In addition, two
>> bits in the TM State High registers are given definitions to help in
>> following the code.
>
> Looks reasonable to me -- not sure why this is an RFC? Does anyone
> object?
Not so far. I'll make it a proper patch.
Larry
prev parent reply other threads:[~2007-03-14 20:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-14 16:18 [RFC] Eliminate some 'G Mode Enable' magic numbers Larry Finger
2007-03-14 19:49 ` John W. Linville
2007-03-14 20:04 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F85546.1010902@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=Bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.