All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tolunay Orkun <betatester@orkun.us>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Fix wrong ID for 28F256P30 in flash.h
Date: Thu, 15 Mar 2007 02:26:35 -0500	[thread overview]
Message-ID: <45F8F52B.9000206@orkun.us> (raw)
In-Reply-To: <9459708.post@talk.nabble.com>

Pete MacKay wrote:
> Intel was inconsistent in their device IDs for the P30 Strata NOR.  The
> header flash.h has incorrect device IDs for the top- and bottom-mapped
> versions of the 32 MB chips as a result.  It's an easy mistake to make...
>
> --- u-boot.git/include/flash.h	2007-03-12 13:40:31.000000000 -0700
> +++ u-boot/include/flash.h	2007-03-12 19:26:25.000000000 -0700
> @@ -290,8 +290,8 @@
>  #define INTEL_ID_28F64P30B  0x881A881A	/*  64M =  32K x 255 + 32k x 4 */
>  #define INTEL_ID_28F128P30T 0x88188818	/* 128M =  64K x 255 + 32k x 4 */
>  #define INTEL_ID_28F128P30B 0x881B881B	/* 128M =  64K x 255 + 32k x 4 */
> -#define INTEL_ID_28F256P30T 0x88198819	/* 256M = 128K x 255 + 32k x 4 */
> -#define INTEL_ID_28F256P30B 0x881C881C	/* 256M = 128K x 255 + 32k x 4 */
> +#define INTEL_ID_28F256P30T 0x89198919	/* 256M = 128K x 255 + 32k x 4 */
> +#define INTEL_ID_28F256P30B 0x891C891C	/* 256M = 128K x 255 + 32k x 4 */
>  
>  #define INTEL_ID_28F160S3   0x00D000D0	/*  16M = 512K x  32 (64kB x 32)	*/
>  #define INTEL_ID_28F320S3   0x00D400D4	/*  32M = 512K x  64 (64kB x 64)	*/
>
>
>   

Thanks for the update. However, the CFI driver actually does not use 
these macro.

Is there a place (custom driver) that this ID was used an caused a problem?

I personally actually want to remove these macros for any device that 
could be serviced by cfi_flash.c driver.

Tolunay

  reply	other threads:[~2007-03-15  7:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-13 17:42 [U-Boot-Users] [PATCH] Fix wrong ID for 28F256P30 in flash.h Pete MacKay
2007-03-15  7:26 ` Tolunay Orkun [this message]
2007-03-15  8:28   ` Wolfgang Denk
2007-03-16  2:57     ` Tolunay Orkun
2007-03-16  9:49       ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45F8F52B.9000206@orkun.us \
    --to=betatester@orkun.us \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.