From mboxrd@z Thu Jan 1 00:00:00 1970 From: PUCCETTI Armand Subject: mini-os: C programming Date: Thu, 15 Mar 2007 14:39:21 +0100 Message-ID: <45F94C89.4010603@cea.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org 2 questions on the code of mini-os (the one in XEN 3.0.3): 1. In xen-3.0.3/extras/mini-os/mm.c:52 is a declaration of stack extern char *stack; but in file xen-3.0.3/extras/mini-os/arch/x86/setup.c:48, there is also a decl of stack: char stack[8192]; If one dereferences the variable stack, which is apparently not the case yet, it gives surely a segfault! 2. In file xen-3.0.3/extras/mini-os/gnttab.c:140: the const variable gnttabop_error_msgs is declared as static const char *gnttabop_error_msgs[] = GNTTABOP_error_msgs; shouldn't that instead be declared: static const char * const gnttabop_error_msgs[] = GNTTABOP_error_msgs; ? (BTW, even the first const is useless as there are consts in GNTTABOP_error_msgs)