From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422969AbXCORFP (ORCPT ); Thu, 15 Mar 2007 13:05:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1422974AbXCORFP (ORCPT ); Thu, 15 Mar 2007 13:05:15 -0400 Received: from mx1.redhat.com ([66.187.233.31]:55344 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422969AbXCORFO (ORCPT ); Thu, 15 Mar 2007 13:05:14 -0400 Message-ID: <45F97C9B.6060503@redhat.com> Date: Thu, 15 Mar 2007 13:04:27 -0400 From: Rik van Riel Organization: Red Hat, Inc User-Agent: Thunderbird 1.5.0.7 (X11/20061008) MIME-Version: 1.0 To: Nick Piggin CC: Chuck Ebbert , Ashif Harji , linux-mm@kvack.org, Jan Kara , linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH] mm/filemap.c: unconditionally call mark_page_accessed References: <20070312142012.GH30777@atrey.karlin.mff.cuni.cz> <20070312143900.GB6016@wotan.suse.de> <20070312151355.GB23532@duck.suse.cz> <20070312173500.GF23532@duck.suse.cz> <20070313185554.GA5105@duck.suse.cz> <45F96CCB.4000709@redhat.com> <20070315162944.GI8321@wotan.suse.de> In-Reply-To: <20070315162944.GI8321@wotan.suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Nick Piggin wrote: > A change to make database style random read() workloads perform better, by > calling mark_page_accessed for some non-page-aligned reads broke the case of > < PAGE_CACHE_SIZE files, which will not get their prev_index moved past the > first page. > > Combine both heuristics for marking the page accessed. > > Signed-off-by: Nick Piggin Acked-by: Rik van Riel -- Politics is the struggle between those who want to make their country the best in the world, and those who believe it already is. Each group calls the other unpatriotic. From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <45F97C9B.6060503@redhat.com> Date: Thu, 15 Mar 2007 13:04:27 -0400 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH] mm/filemap.c: unconditionally call mark_page_accessed References: <20070312142012.GH30777@atrey.karlin.mff.cuni.cz> <20070312143900.GB6016@wotan.suse.de> <20070312151355.GB23532@duck.suse.cz> <20070312173500.GF23532@duck.suse.cz> <20070313185554.GA5105@duck.suse.cz> <45F96CCB.4000709@redhat.com> <20070315162944.GI8321@wotan.suse.de> In-Reply-To: <20070315162944.GI8321@wotan.suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Nick Piggin Cc: Chuck Ebbert , Ashif Harji , linux-mm@kvack.org, Jan Kara , linux-kernel@vger.kernel.org, akpm@linux-foundation.org List-ID: Nick Piggin wrote: > A change to make database style random read() workloads perform better, by > calling mark_page_accessed for some non-page-aligned reads broke the case of > < PAGE_CACHE_SIZE files, which will not get their prev_index moved past the > first page. > > Combine both heuristics for marking the page accessed. > > Signed-off-by: Nick Piggin Acked-by: Rik van Riel -- Politics is the struggle between those who want to make their country the best in the world, and those who believe it already is. Each group calls the other unpatriotic. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org