From: Zachary Amsden <zach@vmware.com>
To: Jan Beulich <jbeulich@novell.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
Ingo Molnar <mingo@elte.hu>,
Virtualization Mailing List <virtualization@lists.osdl.org>,
Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Chris Wright <chrisw@sous-sol.org>, Andi Kleen <ak@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [RFC, PATCH] Fixup COMPAT_VDSO to work with CONFIG_PARAVIRT
Date: Fri, 16 Mar 2007 00:41:38 -0800 [thread overview]
Message-ID: <45FA5842.3070109@vmware.com> (raw)
In-Reply-To: <45FA5E7B.76E4.0078.0@novell.com>
Jan Beulich wrote:
>> So I guess the right thing to do is relocate the dynamic stuff via
>> PT_DYNAMIC, and relocate the symtab if its present.
>>
>
> Symtab should also be deduced from program headers.
>
Learning more all the time..
> I'm actually surprised this got re-implemented from scratch, when my patch
> already had both variants (one just #ifdef-ed out), and was tested in both
> forms (actually, I first implemented the ELF form, and only after seeing the
> bloat it added to the sources I came up her than with the second variant, which in
> the end unfortunately didn't add significantly less bloat to the Makefile.
>
This wasn't re-implemented from scratch - I did this in another lifetime:
http://lists.xensource.com/archives/html/xen-devel/2005-08/msg00284.html
Either way of doing things is fine with me - I would just prefer that if
it has to get down and dirty, we do it in source rather than hidden in a
makefile. But just a personal preference.
Zach
next prev parent reply other threads:[~2007-03-16 8:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-16 2:47 [RFC, PATCH] Fixup COMPAT_VDSO to work with CONFIG_PARAVIRT Zachary Amsden
2007-03-16 3:20 ` Jeremy Fitzhardinge
2007-03-16 3:20 ` Jeremy Fitzhardinge
2007-03-16 4:03 ` Zachary Amsden
2007-03-16 4:03 ` Zachary Amsden
2007-03-16 5:10 ` Jeremy Fitzhardinge
2007-03-16 5:58 ` Zachary Amsden
2007-03-16 5:58 ` Zachary Amsden
2007-03-16 8:08 ` Jan Beulich
2007-03-16 8:41 ` Zachary Amsden [this message]
2007-03-16 16:46 ` Jeremy Fitzhardinge
2007-03-16 17:09 ` Jan Beulich
2007-03-16 23:09 ` Jan Engelhardt
2007-03-16 11:56 ` Eric W. Biederman
2007-03-16 11:56 ` Eric W. Biederman
2007-03-16 16:25 ` Jeremy Fitzhardinge
2007-03-16 16:25 ` Jeremy Fitzhardinge
2007-03-16 16:31 ` Ingo Molnar
2007-03-16 16:33 ` Jeremy Fitzhardinge
2007-03-16 16:33 ` Jeremy Fitzhardinge
2007-03-16 19:06 ` Eric W. Biederman
2007-03-16 19:06 ` Eric W. Biederman
2007-03-16 19:46 ` Jeremy Fitzhardinge
2007-03-16 19:38 ` Zachary Amsden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45FA5842.3070109@vmware.com \
--to=zach@vmware.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=chrisw@sous-sol.org \
--cc=ebiederm@xmission.com \
--cc=jbeulich@novell.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@osdl.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.