From: Larry Finger <larry.finger@lwfinger.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Michael Buesch <mb@bu3sch.de>,
linux-wireless@vger.kernel.org, Bcm43xx-dev@lists.berlios.de
Subject: Re: [PATCH] bcm43xx: Add firmware version to ethtool output
Date: Fri, 16 Mar 2007 13:13:11 -0500 [thread overview]
Message-ID: <45FADE37.2080708@lwfinger.net> (raw)
In-Reply-To: <20070316171427.GC3426@tuxdriver.com>
John W. Linville wrote:
> On Sun, Mar 04, 2007 at 08:02:39PM +0100, Michael Buesch wrote:
>> On Sunday 04 March 2007 19:55, Larry Finger wrote:
>
>>> @@ -42,6 +43,8 @@ static void bcm43xx_get_drvinfo(struct n
>>> strncpy(info->driver, KBUILD_MODNAME, sizeof(info->driver));
>>> strncpy(info->version, utsname()->release, sizeof(info->version));
>>> strncpy(info->bus_info, pci_name(bcm->pci_dev), ETHTOOL_BUSINFO_LEN);
>>> + snprintf(info->fw_version, sizeof(info->fw_version), "0x%x",
>>> + bcm43xx_shm_read16(bcm, BCM43xx_SHM_SHARED, BCM43xx_UCODE_REVISION));
>> This will crash when the device is not up.
>
> Larry, will you be doing a new version of this patch that accounts
> for this comment?
No. Just drop that patch. It doesn't add enough functionality to bother with it.
Larry
prev parent reply other threads:[~2007-03-16 18:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-04 18:55 [PATCH] bcm43xx: Add firmware version to ethtool output Larry Finger
2007-03-04 19:02 ` Michael Buesch
2007-03-16 17:14 ` John W. Linville
2007-03-16 18:13 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45FADE37.2080708@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=Bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.