Re: [PATCH] drivers/char/agp: Convert to generic boolean

[Richard Knutsson <ricknu-0@student.ltu.se>]

Please use "Reply All"

Joe Perches wrote:
> On Sun, 2007-03-18 at 00:45 +0100, Richard Knutsson wrote:
>   
>> diff --git a/drivers/char/agp/amd-k7-agp.c b/drivers/char/agp/amd-k7-agp.c
>> index e6c534e..3d57e9f 100644
>> --- a/drivers/char/agp/amd-k7-agp.c
>> +++ b/drivers/char/agp/amd-k7-agp.c
>> @@ -308,9 +308,9 @@ static int amd_insert_memory(struct agp_memory *mem, off_t pg_start, int type)
>>  		j++;
>>  	}
>>  
>> -	if (mem->is_flushed == FALSE) {
>> +	if (!mem->is_flushed) {
>>  		global_cache_flush();
>> -		mem->is_flushed = TRUE;
>> +		mem->is_flushed = true;
>>  	}
>>     
>
> perhaps a generic.c / agp.h function?
>   
Sound like a good idea (not in a boolean cleanup-patch thou)
Would you mind making that patch?

Richard Knutsson