All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Mark Lord <liml@rtr.ca>
Cc: Jeff Garzik <jgarzik@pobox.com>,
	IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH] libata: add support for ATA_16 on ATAPI
Date: Mon, 19 Mar 2007 13:30:03 +0900	[thread overview]
Message-ID: <45FE11CB.5020500@gmail.com> (raw)
In-Reply-To: <45FA8E96.20909@rtr.ca>

Mark Lord wrote:
> (many months and hours of wasted effort later, still resending..)
> 
> This patch adds support for issuing ATA_16 passthru commands
> to ATAPI devices managed by libata.  It requires the previous
> CDB length fix patch.
> 
> A boot/module parameter, "ata16_passthru=1" can be used to
> globally disable this feature, if ever desired.
> 
> Signed-Off-By: Mark Lord <mlord@pobox.com> ---

It applies with some warnings.

Adds trailing whitespace.
.dotest/patch:47: 
Space in indent is followed by a tab.
.dotest/patch:49:               DPRINTK("bad CDB len=%u, max=%u\n",
Space in indent is followed by a tab.
.dotest/patch:50:                       scmd->cmd_len, max_len);

Other than that.

Acked-by: Tejun Heo <htejun@gmail.com>

-- 
tejun

  reply	other threads:[~2007-03-19  4:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-16 12:33 [PATCH] libata: add support for ATA_16 on ATAPI Mark Lord
2007-03-19  4:30 ` Tejun Heo [this message]
2007-03-19 15:29   ` Mark Lord
2007-03-19 15:32     ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45FE11CB.5020500@gmail.com \
    --to=htejun@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=liml@rtr.ca \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.