From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Anthony Liguori <anthony-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Martin Kaufmann
<martin.kaufmann-/hHgOnHb0V0qcZcGjlUOXw@public.gmane.org>
Subject: Re: kvm-16 fails to compile on Kubuntu Edgy
Date: Mon, 19 Mar 2007 08:43:43 +0200 [thread overview]
Message-ID: <45FE311F.9020008@qumranet.com> (raw)
In-Reply-To: <45FDA76C.6020604-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
Anthony Liguori wrote:
>
> The definition of struct file_system_type.get_sb for 2.6.17 is:
>
> struct super_block *(*get_sb) (struct file_system_type *, int,
> const char *, void *);
>
> So a slightly modified kvmfs_get_sb() is needed. I'm not sure how to
> cope with this though since this #if guard isn't in
> external-module-compat.h. I was under the impression that per-kernel
> version defined were frowned upon in mainline code.
>
> What's the correct solution to this?
>
See the 'sync' target in kernel/Makefile. It looks like all that is
necessary is to add the 2.6.17 case to external-module-compat.h.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
prev parent reply other threads:[~2007-03-19 6:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-18 0:21 kvm-16 fails to compile on Kubuntu Edgy Martin Kaufmann
[not found] ` <45FC8616.20108-/hHgOnHb0V0qcZcGjlUOXw@public.gmane.org>
2007-03-18 2:34 ` richardvoigt-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <2e59e6970703171934q5438a8d1r7e1df582e37e6794-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-03-18 18:22 ` Martin Kaufmann
2007-03-18 18:29 ` Martin Kaufmann
[not found] ` <45FD8509.1080700-/hHgOnHb0V0qcZcGjlUOXw@public.gmane.org>
2007-03-18 19:44 ` richardvoigt-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <2e59e6970703181244x6a19c671k28a9958b3a073922-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-03-18 19:44 ` richardvoigt-Re5JQEeQqe8AvxtiuMwx3w
2007-03-18 12:05 ` Avi Kivity
[not found] ` <45FD2B19.5040100-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-03-18 18:29 ` Martin Kaufmann
2007-03-18 20:56 ` Anthony Liguori
[not found] ` <45FDA76C.6020604-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2007-03-19 6:43 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45FE311F.9020008@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=anthony-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=martin.kaufmann-/hHgOnHb0V0qcZcGjlUOXw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.