From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from schroedinger.engr.sgi.com (schroedinger.engr.sgi.com [150.166.1.51]) by netops-testserver-3.corp.sgi.com (Postfix) with ESMTP id 808B89088D for ; Fri, 16 Mar 2007 15:17:39 -0700 (PDT) Received: from clameter (helo=localhost) by schroedinger.engr.sgi.com with local-esmtp (Exim 3.36 #1 (Debian)) id 1HSKjz-00022n-00 for ; Fri, 16 Mar 2007 15:17:39 -0700 Date: Fri, 16 Mar 2007 15:17:39 -0700 (PDT) From: Christoph Lameter Subject: ZERO_PAGE refcounting causes cache line bouncing Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: linux-mm@kvack.org List-ID: We have issues with ZERO_PAGE refcounting causing severe cacheline bouncing. ZERO_PAGES are mapped into multiple processes running on multiple nodes. Refcounter modifications therefore have to acquire a remote exclusive cacheline. Could we somehow fix this? There are a couple of ways to do this: 1. No refcounting on reserved pages in the VM. ZERO_PAGEs are reserved and there is no point in refcounting them since they will not go away. 2. Having a percpu or pernode ZERO_PAGE? May be a simpler solution but then we still may have issues if the ZERO_PAGE gets "freed" from other processors/ nodes. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 16 Mar 2007 21:35:45 -0700 From: William Lee Irwin III Subject: Re: ZERO_PAGE refcounting causes cache line bouncing Message-ID: <20070317043545.GH8915@holomorphy.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: linux-mm@kvack.org List-ID: On Fri, Mar 16, 2007 at 03:17:39PM -0700, Christoph Lameter wrote: > We have issues with ZERO_PAGE refcounting causing severe cacheline > bouncing. ZERO_PAGES are mapped into multiple processes running on > multiple nodes. Refcounter modifications therefore have to acquire a > remote exclusive cacheline. > Could we somehow fix this? There are a couple of ways to do this: > 1. No refcounting on reserved pages in the VM. ZERO_PAGEs are > reserved and there is no point in refcounting them since they > will not go away. > 2. Having a percpu or pernode ZERO_PAGE? > May be a simpler solution but then we still may have issues > if the ZERO_PAGE gets "freed" from other processors/ nodes. It's dumb to refcount the zero page. Someone should've noticed this when the PG_reserved patches went in. I can't think of an easy way around this apart from a backout. OTOH it's a simple matter of programming to arrange for it without a backout. Provisions should be made for per-node zero pages in addition to this. AFAICT the primary thing needed is to wrap checks for a page being a zero page with some testing function instead of using a raw equality check. This is above and beyond solving the mere zero page refcount problem; I'm saying that both proposals should be done even though only one is needed to resolve the bouncing issue. I guess this is an "ack of the concept" of sorts. None of this is so involved that I should jump on it and try to get a patch out ahead of you. -- wli -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <45FE261F.3030903@yahoo.com.au> Date: Mon, 19 Mar 2007 16:56:47 +1100 From: Nick Piggin MIME-Version: 1.0 Subject: Re: ZERO_PAGE refcounting causes cache line bouncing References: <20070317043545.GH8915@holomorphy.com> In-Reply-To: <20070317043545.GH8915@holomorphy.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: William Lee Irwin III Cc: Christoph Lameter , linux-mm@kvack.org List-ID: William Lee Irwin III wrote: > On Fri, Mar 16, 2007 at 03:17:39PM -0700, Christoph Lameter wrote: > >>We have issues with ZERO_PAGE refcounting causing severe cacheline >>bouncing. ZERO_PAGES are mapped into multiple processes running on >>multiple nodes. Refcounter modifications therefore have to acquire a >>remote exclusive cacheline. >>Could we somehow fix this? There are a couple of ways to do this: >>1. No refcounting on reserved pages in the VM. ZERO_PAGEs are >> reserved and there is no point in refcounting them since they >> will not go away. >>2. Having a percpu or pernode ZERO_PAGE? >> May be a simpler solution but then we still may have issues >> if the ZERO_PAGE gets "freed" from other processors/ nodes. > > > It's dumb to refcount the zero page. Someone should've noticed this > when the PG_reserved patches went in. The patch author did notice ;) http://groups.google.com/group/fa.linux.kernel/msg/48108a5faa20a667?hl=en& But was subsequently told that special casing the ZERO_PAGE was stupid (as if it isn't a special object in the VM), and so it was removed (and a warning added to the changelog) http://lwn.net/Articles/155280/ I also subsequently submitted a standalone patch to reintroduce it after the core patch was merged, but again was rejected (can't find the link for that one, off hand). > I can't think of an easy way > around this apart from a backout. OTOH it's a simple matter of > programming to arrange for it without a backout. Yes, I have the patch to do it quite easily. Per-node ZERO_PAGE could be another option, but that's going to cost another page flag if we wish to recognise the zero page in wp faults like we do now (hmm, for some reason it is OK to special case it _there_). > Provisions should be made for per-node zero pages in addition to this. > AFAICT the primary thing needed is to wrap checks for a page being a > zero page with some testing function instead of using a raw equality > check. This is above and beyond solving the mere zero page refcount > problem; I'm saying that both proposals should be done even though only > one is needed to resolve the bouncing issue. I've always thought the bouncing issue was a silly one and should be fixed, of course. Maybe the reason my fix was vetoed was lack of numbers. Christoph, would you oblige? I'll dig out the patch and repost. -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <45FE3092.3030202@yahoo.com.au> Date: Mon, 19 Mar 2007 17:41:22 +1100 From: Nick Piggin MIME-Version: 1.0 Subject: Re: ZERO_PAGE refcounting causes cache line bouncing References: <20070317043545.GH8915@holomorphy.com> <45FE261F.3030903@yahoo.com.au> <45FE2CA0.3080204@yahoo.com.au> In-Reply-To: <45FE2CA0.3080204@yahoo.com.au> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Nick Piggin Cc: William Lee Irwin III , Christoph Lameter , linux-mm@kvack.org List-ID: Nick Piggin wrote: > Something like this roughly should get rid of ZERO_PAGE _count and > _mapcount > manipulation for anonymous pages. (others still exist, XIP and > /dev/zero, but > they should not be a large concern AFAIKS). > > I haven't booted this, but it is a quick forward port + some fixes and > simplifications. > > > ------------------------------------------------------------------------ > > Index: linux-2.6/mm/memory.c > =================================================================== > --- linux-2.6.orig/mm/memory.c > +++ linux-2.6/mm/memory.c > @@ -665,7 +665,8 @@ static unsigned long zap_pte_range(struc > ptent = ptep_get_and_clear_full(mm, addr, pte, > tlb->fullmm); > tlb_remove_tlb_entry(tlb, pte, addr); > - if (unlikely(!page)) > + if (unlikely(!page || > + (!vma->vm_file && page == ZERO_PAGE(addr)))) > continue; Hmm, well I suppose it would be cleaner if this check used the one in handle_pte_fault instead of !vma->vm_file ie. (!vma->vm_ops || !vma->vm_ops->nopage) > if (unlikely(details) && details->nonlinear_vma > && linear_page_index(details->nonlinear_vma, > @@ -2152,15 +2153,12 @@ static int do_anonymous_page(struct mm_s > } else { > /* Map the ZERO_PAGE - vm_page_prot is readonly */ > page = ZERO_PAGE(address); > - page_cache_get(page); > entry = mk_pte(page, vma->vm_page_prot); > > ptl = pte_lockptr(mm, pmd); > spin_lock(ptl); > if (!pte_none(*page_table)) > - goto release; > - inc_mm_counter(mm, file_rss); > - page_add_file_rmap(page); > + goto unlock; > } > > set_pte_at(mm, address, page_table, entry); -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <45FE6040.4090809@yahoo.com.au> Date: Mon, 19 Mar 2007 21:04:48 +1100 From: Nick Piggin MIME-Version: 1.0 Subject: Re: ZERO_PAGE refcounting causes cache line bouncing References: <20070317043545.GH8915@holomorphy.com> <45FE261F.3030903@yahoo.com.au> <45FE2CA0.3080204@yahoo.com.au> <45FE3092.3030202@yahoo.com.au> In-Reply-To: <45FE3092.3030202@yahoo.com.au> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Nick Piggin Cc: William Lee Irwin III , Christoph Lameter , linux-mm@kvack.org List-ID: Nick Piggin wrote: > Nick Piggin wrote: > >> Something like this roughly should get rid of ZERO_PAGE _count and >> _mapcount >> manipulation for anonymous pages. (others still exist, XIP and >> /dev/zero, but >> they should not be a large concern AFAIKS). >> >> I haven't booted this, but it is a quick forward port + some fixes and >> simplifications. >> >> >> ------------------------------------------------------------------------ >> >> Index: linux-2.6/mm/memory.c >> =================================================================== >> --- linux-2.6.orig/mm/memory.c >> +++ linux-2.6/mm/memory.c >> @@ -665,7 +665,8 @@ static unsigned long zap_pte_range(struc >> ptent = ptep_get_and_clear_full(mm, addr, pte, >> tlb->fullmm); >> tlb_remove_tlb_entry(tlb, pte, addr); >> - if (unlikely(!page)) >> + if (unlikely(!page || >> + (!vma->vm_file && page == ZERO_PAGE(addr)))) >> continue; > > > Hmm, well I suppose it would be cleaner if this check used the one in > handle_pte_fault instead of !vma->vm_file ie. (!vma->vm_ops || > !vma->vm_ops->nopage) Bah, I also missed a reject for a similar hunk required in copy_one_pte. I don't think there is anything more required after that, though... I will actually test it tomorrow and send an updated patch with proper changelog. -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 19 Mar 2007 07:03:47 -0500 From: Robin Holt Subject: Re: ZERO_PAGE refcounting causes cache line bouncing Message-ID: <20070319120347.GB6694@lnx-holt.americas.sgi.com> References: <20070317043545.GH8915@holomorphy.com> <45FE261F.3030903@yahoo.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45FE261F.3030903@yahoo.com.au> Sender: owner-linux-mm@kvack.org Return-Path: To: Nick Piggin Cc: William Lee Irwin III , Christoph Lameter , linux-mm@kvack.org List-ID: On Mon, Mar 19, 2007 at 04:56:47PM +1100, Nick Piggin wrote: > Yes, I have the patch to do it quite easily. Per-node ZERO_PAGE could be > another option, but that's going to cost another page flag if we wish to > recognise the zero page in wp faults like we do now (hmm, for some reason > it is OK to special case it _there_). Could we do a per-node ZERO_PAGE as a pointer from the node structure and then use a page_to_nid to get back to the node and compare the page to the node's zero page instead of using another page flag which would actually only be used on numa? Thanks, Robin -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 19 Mar 2007 05:46:30 -0700 From: William Lee Irwin III Subject: Re: ZERO_PAGE refcounting causes cache line bouncing Message-ID: <20070319124630.GK8915@holomorphy.com> References: <20070317043545.GH8915@holomorphy.com> <45FE261F.3030903@yahoo.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45FE261F.3030903@yahoo.com.au> Sender: owner-linux-mm@kvack.org Return-Path: To: Nick Piggin Cc: Christoph Lameter , linux-mm@kvack.org List-ID: On Mon, Mar 19, 2007 at 04:56:47PM +1100, Nick Piggin wrote: > Yes, I have the patch to do it quite easily. Per-node ZERO_PAGE could be > another option, but that's going to cost another page flag if we wish to > recognise the zero page in wp faults like we do now (hmm, for some reason > it is OK to special case it _there_). No need for a page flag. A per-node array of struct page * can be used to check by merely indexing into it with the nid of the page's node. e.g. struct page *get_zero_page(int nid, unsigned long addr) { return zero_pages[nid][(addr & SOME_ARCHDEP_MASK) >> PAGE_SHIFT]; } /* any time we fish one out of a pte we have a uvaddr */ int is_zero_page_addr(struct page *page, unsigned long address) { return page == get_zero_page(page_to_nid(page), address); } -- wli -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 19 Mar 2007 10:04:10 -0700 (PDT) From: Christoph Lameter Subject: Re: ZERO_PAGE refcounting causes cache line bouncing In-Reply-To: <45FE261F.3030903@yahoo.com.au> Message-ID: References: <20070317043545.GH8915@holomorphy.com> <45FE261F.3030903@yahoo.com.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Nick Piggin Cc: William Lee Irwin III , linux-mm@kvack.org List-ID: On Mon, 19 Mar 2007, Nick Piggin wrote: > I've always thought the bouncing issue was a silly one and should be > fixed, of course. Maybe the reason my fix was vetoed was lack of numbers. > Christoph, would you oblige? I'll dig out the patch and repost. Well this occurs on a 1024p system that is only sporadically available. It gets so bad it hangs completely. Could you also provide patch against SLES10? We get get some bug action on this one I think. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 19 Mar 2007 10:06:36 -0700 (PDT) From: Christoph Lameter Subject: Re: ZERO_PAGE refcounting causes cache line bouncing In-Reply-To: <45FE2CA0.3080204@yahoo.com.au> Message-ID: References: <20070317043545.GH8915@holomorphy.com> <45FE261F.3030903@yahoo.com.au> <45FE2CA0.3080204@yahoo.com.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Nick Piggin Cc: William Lee Irwin III , linux-mm@kvack.org List-ID: On Mon, 19 Mar 2007, Nick Piggin wrote: > I haven't booted this, but it is a quick forward port + some fixes and > simplifications. Eeek patch vanished. The comparison with ZERO_PAGE may fail if we have multiple zero pages. Would it be possible to check for PageReserved? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <45FE2CA0.3080204@yahoo.com.au> Date: Mon, 19 Mar 2007 17:24:32 +1100 From: Nick Piggin MIME-Version: 1.0 Subject: Re: ZERO_PAGE refcounting causes cache line bouncing References: <20070317043545.GH8915@holomorphy.com> <45FE261F.3030903@yahoo.com.au> In-Reply-To: <45FE261F.3030903@yahoo.com.au> Content-Type: multipart/mixed; boundary="------------050102090906080701000400" Sender: owner-linux-mm@kvack.org Return-Path: Cc: William Lee Irwin III , Christoph Lameter , linux-mm@kvack.org List-ID: This is a multi-part message in MIME format. --------------050102090906080701000400 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Nick Piggin wrote: > I've always thought the bouncing issue was a silly one and should be > fixed, of course. Maybe the reason my fix was vetoed was lack of numbers. > Christoph, would you oblige? I'll dig out the patch and repost. Something like this roughly should get rid of ZERO_PAGE _count and _mapcount manipulation for anonymous pages. (others still exist, XIP and /dev/zero, but they should not be a large concern AFAIKS). I haven't booted this, but it is a quick forward port + some fixes and simplifications. -- SUSE Labs, Novell Inc. --------------050102090906080701000400 Content-Type: text/plain; name="mm-special-case-ZERO_PAGE.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="mm-special-case-ZERO_PAGE.patch" Index: linux-2.6/mm/memory.c =================================================================== --- linux-2.6.orig/mm/memory.c +++ linux-2.6/mm/memory.c @@ -665,7 +665,8 @@ static unsigned long zap_pte_range(struc ptent = ptep_get_and_clear_full(mm, addr, pte, tlb->fullmm); tlb_remove_tlb_entry(tlb, pte, addr); - if (unlikely(!page)) + if (unlikely(!page || + (!vma->vm_file && page == ZERO_PAGE(addr)))) continue; if (unlikely(details) && details->nonlinear_vma && linear_page_index(details->nonlinear_vma, @@ -2152,15 +2153,12 @@ static int do_anonymous_page(struct mm_s } else { /* Map the ZERO_PAGE - vm_page_prot is readonly */ page = ZERO_PAGE(address); - page_cache_get(page); entry = mk_pte(page, vma->vm_page_prot); ptl = pte_lockptr(mm, pmd); spin_lock(ptl); if (!pte_none(*page_table)) - goto release; - inc_mm_counter(mm, file_rss); - page_add_file_rmap(page); + goto unlock; } set_pte_at(mm, address, page_table, entry); --------------050102090906080701000400-- Send instant messages to your online friends http://au.messenger.yahoo.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <45FF481C.8070907@yahoo.com.au> Date: Tue, 20 Mar 2007 13:34:04 +1100 From: Nick Piggin MIME-Version: 1.0 Subject: Re: ZERO_PAGE refcounting causes cache line bouncing References: <20070317043545.GH8915@holomorphy.com> <45FE261F.3030903@yahoo.com.au> <20070319124630.GK8915@holomorphy.com> In-Reply-To: <20070319124630.GK8915@holomorphy.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: William Lee Irwin III Cc: Christoph Lameter , linux-mm@kvack.org List-ID: William Lee Irwin III wrote: > On Mon, Mar 19, 2007 at 04:56:47PM +1100, Nick Piggin wrote: > >>Yes, I have the patch to do it quite easily. Per-node ZERO_PAGE could be >>another option, but that's going to cost another page flag if we wish to >>recognise the zero page in wp faults like we do now (hmm, for some reason >>it is OK to special case it _there_). > > > No need for a page flag. A per-node array of struct page * can be used > to check by merely indexing into it with the nid of the page's node. e.g. > > struct page *get_zero_page(int nid, unsigned long addr) > { > return zero_pages[nid][(addr & SOME_ARCHDEP_MASK) >> PAGE_SHIFT]; > } > > /* any time we fish one out of a pte we have a uvaddr */ > int is_zero_page_addr(struct page *page, unsigned long address) > { > return page == get_zero_page(page_to_nid(page), address); > } Ah, good point :) -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <45FF488E.6060707@yahoo.com.au> Date: Tue, 20 Mar 2007 13:35:58 +1100 From: Nick Piggin MIME-Version: 1.0 Subject: Re: ZERO_PAGE refcounting causes cache line bouncing References: <20070317043545.GH8915@holomorphy.com> <45FE261F.3030903@yahoo.com.au> <20070319120347.GB6694@lnx-holt.americas.sgi.com> In-Reply-To: <20070319120347.GB6694@lnx-holt.americas.sgi.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Robin Holt Cc: William Lee Irwin III , Christoph Lameter , linux-mm@kvack.org List-ID: Robin Holt wrote: > On Mon, Mar 19, 2007 at 04:56:47PM +1100, Nick Piggin wrote: > >>Yes, I have the patch to do it quite easily. Per-node ZERO_PAGE could be >>another option, but that's going to cost another page flag if we wish to >>recognise the zero page in wp faults like we do now (hmm, for some reason >>it is OK to special case it _there_). > > > Could we do a per-node ZERO_PAGE as a pointer from the node structure > and then use a page_to_nid to get back to the node and compare the page > to the node's zero page instead of using another page flag which would > actually only be used on numa? Yes, that's a nice way to do it. -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <45FF4CAB.2000306@yahoo.com.au> Date: Tue, 20 Mar 2007 13:53:31 +1100 From: Nick Piggin MIME-Version: 1.0 Subject: Re: ZERO_PAGE refcounting causes cache line bouncing References: <20070317043545.GH8915@holomorphy.com> <45FE261F.3030903@yahoo.com.au> <45FE2CA0.3080204@yahoo.com.au> In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: William Lee Irwin III , linux-mm@kvack.org List-ID: Christoph Lameter wrote: > On Mon, 19 Mar 2007, Nick Piggin wrote: > > >>I haven't booted this, but it is a quick forward port + some fixes and >>simplifications. > > > Eeek patch vanished. > > The comparison with ZERO_PAGE may fail if we have multiple zero pages. > Would it be possible to check for PageReserved? That still wasn't quite right either. I don't want to check for PageReserved, because I want to get rid of that flag one day. The Robin/Bill approach for multiple zero pages will work, though. -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org